Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ add token examples #706 #718

Closed
wants to merge 3 commits into from
Closed

Feature/ add token examples #706 #718

wants to merge 3 commits into from

Conversation

j-chimienti
Copy link

Fixes #706

adds examples and tests for TokenTimelock and TokenVesting examples

πŸš€ Description

  • πŸ“˜ I've reviewed the OpenZeppelin Contributor Guidelines
  • βœ… I've added tests where applicable to test my new functionality.
  • πŸ“– I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

joe added 3 commits February 3, 2018 09:28
issue: no examples of TokenTimelock or TokenVesting usage

fixes: add examples and tests
Copy link

@pavsh pavsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's an example so it should be more detailed and i would add how it works with the crowdsale contract. show a full example for an ICO

@nventuro nventuro self-assigned this Jul 28, 2018
@nventuro nventuro added kind:improvement documentation Inline comments, guides, and examples. labels Jul 28, 2018
@nventuro nventuro added this to the v2.0 milestone Jul 28, 2018
@nventuro
Copy link
Contributor

Hi @j-chimienti, thanks for your contribution!

I may be missing something, but from what I can tell, these samples don't actually extend the base contracts in any way, they simply delegate construction to them. In that sense, they are not really examples, but rather extra tests to the original contracts. Was that your intent with this PR?

@nventuro
Copy link
Contributor

Closing due to inactivity/intent not being clear (see above).

@nventuro nventuro closed this Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Inline comments, guides, and examples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples on TokenTimeLock and TokenVesting
4 participants