Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC721Deed #747

Closed

Conversation

nastassiasachs
Copy link

Fixes #627 Implement ERC standard

🚀 Description

Recently deed has been introduced as a term to refer to non-fungible tokens (see ethereum/EIPs#841). This is an attempt at implementing the current state of the ERC721 interface.
(Sorry, I don't know why the Bounty contract tests failed on my end.)

  • [ x ] 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • [ x ] ✅ I've added tests where applicable to test my new functionality.
  • [ x ] 📖 I've made sure that my contracts are well-documented.
  • [ x ] 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

@spalladino
Copy link
Contributor

Thanks for the PR @nastassiasachs, but we understand there was no consensus around the rename to deed. I'm closing this issue now, and the full implementation for ERC721 is continuing in #803.

@spalladino spalladino closed this Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants