Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Use Array.isArray instead of lodash.isarray #1127

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Use Array.isArray instead of lodash.isarray #1127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions packages/cli/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@
"lodash.frompairs": "^4.0.1",
"lodash.groupby": "^4.6.0",
"lodash.intersection": "^4.4.0",
"lodash.isarray": "^4.0.0",
"lodash.isempty": "^4.4.0",
"lodash.isequal": "^4.5.0",
"lodash.isnil": "^4.0.0",
Expand Down
3 changes: 1 addition & 2 deletions packages/cli/src/utils/async.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import map from 'lodash.map';
import isEmpty from 'lodash.isempty';
import isArray from 'lodash.isarray';

export async function allPromisesOrError(
promisesWithObjects: any[],
Expand All @@ -11,7 +10,7 @@ export async function allPromisesOrError(
let promise;
let object = null;
try {
if (isArray(item)) {
if (Array.isArray(item)) {
[promise, object] = item;
} else {
promise = item;
Expand Down
39 changes: 0 additions & 39 deletions packages/lib/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@
"lodash.flatten": "^4.4.0",
"lodash.includes": "^4.3.0",
"lodash.invertby": "^4.7.0",
"lodash.isarray": "^4.0.0",
"lodash.isempty": "^4.4.0",
"lodash.isequal": "^4.5.0",
"lodash.isstring": "^4.0.1",
Expand Down
6 changes: 2 additions & 4 deletions packages/lib/src/utils/Semver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import semver from 'semver';
import isString from 'lodash.isstring';
import isArray from 'lodash.isarray';

import util from 'util';

// TS-TODO: use typed SemVer dependency, some of these methods may actually
Expand All @@ -15,7 +13,7 @@ export function toSemanticVersion(version: string | RawSemanticVersion): Semanti
const semanticVersion: any = semver.parse(version as string);
if (!semanticVersion) throw Error(`Cannot parse version identifier ${version}`);
return [semanticVersion.major, semanticVersion.minor, semanticVersion.patch];
} else if (isArray(version) && version.length === 3) {
} else if (Array.isArray(version) && version.length === 3) {
version = (version as RawSemanticVersion).map(Number) as [number, number, number];
const semverGenericArray: RawSemanticVersion = version as RawSemanticVersion;
const semverTyped: number[] = semverGenericArray.map((x: any) => {
Expand All @@ -27,7 +25,7 @@ export function toSemanticVersion(version: string | RawSemanticVersion): Semanti

export function semanticVersionToString(version: string | RawSemanticVersion): string | never {
if (isString(version)) return version as string;
else if (isArray(version)) {
else if (Array.isArray(version)) {
const semverGenericArray: RawSemanticVersion = version as RawSemanticVersion;
return semverGenericArray.join('.') as string;
} else throw Error(`Cannot handle version identifier ${util.inspect(version)}`);
Expand Down