Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Validate init params #1148

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Validate init params #1148

merged 1 commit into from
Jul 22, 2019

Conversation

spalladino
Copy link
Contributor

Validates that name is not empty, and that version is semver compatible. Only on interactive command.

Fixes #1142

Validates that name is not empty, and that version is semver compatible. Only on interactive command.

Fixes #1142
Copy link
Contributor

@ylv-io ylv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
Side question – should we prefer 0.1.0 over 1.0.0 as default version?

@spalladino
Copy link
Contributor Author

Side question – should we prefer 0.1.0 over 1.0.0 as default version?

I used npm's default to be honest

@spalladino spalladino merged commit fb42ffb into master Jul 22, 2019
@spalladino spalladino deleted the fix/validate-init-params branch July 22, 2019 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Enforce Semantic Versioning when running oz init.
2 participants