Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Sort commands in alphabetical order for oz --help and docs #1321

Merged
merged 5 commits into from
Dec 13, 2019
Merged

Sort commands in alphabetical order for oz --help and docs #1321

merged 5 commits into from
Dec 13, 2019

Conversation

abcoathup
Copy link
Contributor

Sort commands in alphabetical order for oz --help and docs

Added sort to program.ts

Fixes #1320

@abcoathup abcoathup requested a review from spalladino December 12, 2019 08:02
Copy link
Contributor

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Andy, kudos! I'm approving in case you want to merge as-is, but I'd suggest using sortBy instead (installing this package), which would make the comparison function even simpler.

That package is part of lodash, a library with many convenience functions for javascript. We are not importing the full library, but add each function as a separate package as we need them.

@frangio
Copy link
Contributor

frangio commented Dec 12, 2019

Updated with the latest master to include #1323.

@abcoathup
Copy link
Contributor Author

Updated to lodash.sortBy
Thanks for the suggestion, much nicer.

@abcoathup abcoathup requested a review from spalladino December 13, 2019 10:21
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frangio frangio merged commit c313a79 into OpenZeppelin:master Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show CLI commands in alphabetical order in oz --help and in docs
3 participants