This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Stop interactive create or update on validation errors #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
changed the title
spalladino
force-pushed
the
fix/abort-deploy-on-validation-errors-#1348
branch
from
7e2a139 to
5d1937f
Compare
frangio
approved these changes
Jan 13, 2020
packages/cli/src/commands/push.ts
Outdated
| } | ||
| } | ||
| const { interactive } = options; | ||
| if (!interactive) return; |
There was a problem hiding this comment.
I personally prefer 1) avoiding early returns, and 2) always using braces. The latter should be a linter rule if we even agree to it, so I won't insist on it.
There was a problem hiding this comment.
-
I like returns either at the beginning or the end, though not in the middle. Returns at the very first lines of the function feel natural as they are kind of "validations" of whether we want to run or not. Agree on avoiding them in the middle.
-
I particularly line single-line ifs when it's a return. Seems like we're on opposite sides on this one!
There was a problem hiding this comment.
Actually, just changed this so the return is on the very first line.
The force flag was being passed to push from both create and upgrade to force pushing the implementation contracts. This caused the contracts to be pushed even if they had validation errors. This commit removes that flag so the create or upgrade fails if there are any errors. Fixes #1348
spalladino
force-pushed
the
fix/abort-deploy-on-validation-errors-#1348
branch
from
5d1937f to
d517f42
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The force flag was being passed to push from both create and upgrade to force pushing the implementation contracts. This caused the contracts to be pushed even if they had validation errors. This commit removes that flag so the create or upgrade fails if there are any errors.
Fixes #1348