This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Add url and path properties to network config #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
Looks great! I love the refactor in getProvider, the old code was unnecessarily hard to read.
For future PRs, consider applying changes that greatly affect indentation (like the removal of the outer context blocks in the tests) in a separate commit: it otherwise makes reviewing the changes much harder.
|
With this change we can now use the CLI on public networks by connecting to Infura with no mnemonics (read-only) 🎊 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for specifying an url entry with the full URL to the node. Also adds a new entry, path, that can be combined with host, protocol, and port, and makes port optional. Note that #1338 suggested accepting a path as part of the host, though this is not technically correct (hence the new path property).
Fixes #1338