Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename templates binaries in the zombienet files #290

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

AlexD10S
Copy link
Contributor

@AlexD10S AlexD10S commented Aug 16, 2024

This PR adds force_decorator = "generic-evm" in the devnet.toml of the EVM parachain as suggested in paritytech/zombienet#1826. Closes #289

This PR also renames the parachain binaries in the Zombienet files of the generic-template and evm-template to enhance the UX. With this change users don't have to to manually rename the binaries.

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for docs-oz-polkadot canceled.

Name Link
🔨 Latest commit d4dc215
🔍 Latest deploy log https://app.netlify.com/sites/docs-oz-polkadot/deploys/66bf66ec642b6d000846e380

Copy link
Collaborator

@ozgunozerk ozgunozerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing the typo

@ozgunozerk
Copy link
Collaborator

I tried this on our repo, and it didn't work out. Turns out we needed to bump the zombienet version we used. Updating our scripts in #292

Copy link
Collaborator

@ozgunozerk ozgunozerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 💯

@ozgunozerk ozgunozerk requested review from KitHat and 4meta5 August 19, 2024 06:33
@ozgunozerk ozgunozerk merged commit ab82cb3 into OpenZeppelin:main Aug 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

🐞 [Bug]: EVM Template Fails to Spawn with Zombienet
3 participants