Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove constructor from abi #247

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

qalisander
Copy link
Member

No description provided.

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for contracts-stylus canceled.

Name Link
🔨 Latest commit dbc0268
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/66c316dac532a9000747a7db

@@ -1,8 +1,7 @@
//! Contract module that allows children to implement role-based access control
//! mechanisms. This is a lightweight version that doesn't allow enumerating
//! role members except through off-chain means by accessing the contract event
//! logs. Some applications may benefit from on-chain enumerability, for those
//! cases see [`AccessControlEnumberable`][enumerable ext].
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have it implemented. Hence remove it

@qalisander qalisander marked this pull request as ready for review August 19, 2024 07:40
@qalisander qalisander changed the title chore: remove constructors from abi chore: remove obsolete constructor functions from abi Aug 19, 2024
@qalisander qalisander marked this pull request as draft August 19, 2024 07:43
@qalisander qalisander changed the title chore: remove obsolete constructor functions from abi chore: remove constructor from abi Aug 19, 2024
@qalisander qalisander marked this pull request as ready for review August 19, 2024 08:08
Copy link
Contributor

@alexfertel alexfertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that typos did not catch literla.

LGTM!

@alexfertel
Copy link
Contributor

crate-ci/typos#1069 (comment) should be caught next time.

@bidzyyys bidzyyys merged commit 94497e6 into main Aug 19, 2024
21 checks passed
@bidzyyys bidzyyys deleted the remove-function-consructor-artifacts-from-code branch August 19, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants