Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new transcription management (subtitles) in Opencast 15 #373

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ferishili
Copy link
Contributor

This PR fixes #368

Description

In Opencast 15 the subtitles format has been changed drastically, in a form that the flavor now contains captions/delivery and other info like language etc. will be provided in the tags.

Solution

  • In order for us to provide backward compatibility we remain by using mediapackages for upload/delete.
  • The three cases (attachment, media (old) and media (new)) are covered.
  • The manual transcription upload is still following captions/vtt+{lang}, simply because to maintain the difference as well as the lack of capability to upload extra tags info via add_track.

Goal

the ultimate goal is to be able to manage (delete/download/upload) manual and auto generated subtitles for an event. In order to achieve this goal it might happen that workflows has to be updated (specially republich-metadata-and-captions workflow) to cover all cases.

NOTE

Consider this PR as a beta version, because this subtitle upgrade is still fresh and might result in unexpected behaviors, therefore, this PR may have further updates

@ferishili ferishili added enhancement maintenance For those issues that are not bugs but have some logical/functionality issues labels Mar 26, 2024
@ferishili ferishili self-assigned this Mar 26, 2024
@KatrinIhler
Copy link

The manual transcription upload is still following captions/vtt+{lang}, simply because to maintain the difference as well as the lack of capability to upload extra tags info via add_track.

Is this a good idea? We should try and follow the new format.

In regards to the tagging problem see opencast/opencast#5866

@ferishili
Copy link
Contributor Author

ferishili commented May 28, 2024

The manual transcription upload is still following captions/vtt+{lang}, simply because to maintain the difference as well as the lack of capability to upload extra tags info via add_track.

Is this a good idea? We should try and follow the new format.

In regards to the tagging problem see opencast/opencast#5866

At the time of implementing this, and still (the tagging feature request issue comes from Till & I to tackle this), there was no other option when using addTrack endpoint to include tags. Also, this feature goes back to almost 3 years ago and there are many institutions that are still using attachment! So removing this feature was not an option, but to maintain the old flavor!

As soon as the tagging is possible via the endpoint, we need to update it here as well!

@KatrinIhler
Copy link

KatrinIhler commented May 31, 2024

@ferishili Okay, I can see why backwards compatibility would be important. And if this will support the new use case as well (when the tagging PR is through), then that's fine.

Copy link
Collaborator

@justusdieckmann justusdieckmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, the code looks good to me. Thank you very much!

Of course tests would be amazing. I think it would probably a good idea to look into which features we have in the plugin, and which ones are tested in which way (against live local opencast or simulated requests)

@ferishili
Copy link
Contributor Author

Hi @justusdieckmann, hi @bluetom
Since this PR is approved and has no conflicts, I would say, it is ready to merge.
Please have a look and let me know if there is something left here.
Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.5.1 enhancement maintenance For those issues that are not bugs but have some logical/functionality issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subtitles are not available in the Moodle Block Plugin under Manage Transcriptions
3 participants