Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Opencast PHP Library to 1.8.0 + Api Version setting (OC 16 Support) + Moodle 4.4 Required Changes #63

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ferishili
Copy link
Contributor

@ferishili ferishili commented Sep 20, 2024

This PR fixes #62.

It consists of two part:

  • The upgrade of the Opencast PHP Library to 1.8.0 which is important to use the plugin for Opencast 16
  • A new setting is instroduced: "Opencast API Version", which helps improve the performance when configured correctly!

New settings:

UPDATE: The api version setting has been removed, in favor of hard-coding the api version (if any) as it is a developer matter, not an admin to take care of!
Admins are now able to add the api version for each instance:

  • configuring it improves performance by eliminating an automated step by which the api version is extracted.

  • If not sure how to find it just use this link format to get is: [your opencast address]/docs.html?path=/api#getversiondefault-8

  • By leaving it empty, it does what it did like before!

Please note:
This PR also contains the required changes to Moodle 4.4, otherwise the Actions "CI"s won't work

@ferishili ferishili added the enhancement New feature or request label Sep 20, 2024
@ferishili ferishili self-assigned this Sep 20, 2024
@ferishili ferishili changed the title Upgrade Opencast PHP Library to 1.8.0 + Api Version setting Upgrade Opencast PHP Library to 1.8.0 + Api Version setting (OC 16 Support) Sep 20, 2024
@ferishili ferishili changed the title Upgrade Opencast PHP Library to 1.8.0 + Api Version setting (OC 16 Support) Upgrade Opencast PHP Library to 1.8.0 + Api Version setting (OC 16 Support) + Moodle 4.4 Required Changes Sep 23, 2024
@ferishili
Copy link
Contributor Author

ferishili commented Sep 30, 2024

Because this PR is being use in some new changes in block_opencast plugin, specifically for the sake of passing workflow configurations into the ingest api, therefore a new branch out of this PR has been created: https://github.com/Opencast-Moodle/moodle-tool_opencast/tree/oc-16-support

@geichelberger
Copy link

I think we should hardcode the minimum required API version, as it should be a developer thing to decide which API version is needed if we want to support different feature sets based on a configuration to support several Opencast Versions; it should be a curated version List, maybe with just the Opencast Version as the API version only changes with major releases.

@ferishili
Copy link
Contributor Author

it should be a curated version List, maybe with just the Opencast Version as the API version only changes with major releases.

Hi @geichelberger,
if I understood your suggestion correctly, at the end of the day (and for the sake of backward compatibility of OC versions) we need to get the Opencast Version either automatically (it is done via sysinfo endpoint - which is not under api) or by user (admin) input through settings.
I am correct? What is your opinion?

@ferishili
Copy link
Contributor Author

The api version setting has been reverted and it went back to the normal automatic way like before for now, until we decide if it is necessary to add hard-coded api versions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.5.1 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opencast PHP Library Upgrade (v.1.8.0)
2 participants