-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Opencast PHP Library to 1.8.0 + Api Version setting (OC 16 Support) + Moodle 4.4 Required Changes #63
base: master
Are you sure you want to change the base?
Conversation
Because this PR is being use in some new changes in block_opencast plugin, specifically for the sake of passing workflow configurations into the ingest api, therefore a new branch out of this PR has been created: https://github.com/Opencast-Moodle/moodle-tool_opencast/tree/oc-16-support |
I think we should hardcode the minimum required API version, as it should be a developer thing to decide which API version is needed if we want to support different feature sets based on a configuration to support several Opencast Versions; it should be a curated version List, maybe with just the Opencast Version as the API version only changes with major releases. |
Hi @geichelberger, |
The api version setting has been reverted and it went back to the normal automatic way like before for now, until we decide if it is necessary to add hard-coded api versions! |
This PR fixes #62.
It consists of two part:
New settings:
UPDATE: The api version setting has been removed, in favor of hard-coding the api version (if any) as it is a developer matter, not an admin to take care of!
Admins are now able to add the api version for each instance:configuring it improves performance by eliminating an automated step by which the api version is extracted.If not sure how to find it just use this link format to get is: [your opencast address]/docs.html?path=/api#getversiondefault-8By leaving it empty, it does what it did like before!Please note:
This PR also contains the required changes to Moodle 4.4, otherwise the Actions "CI"s won't work