Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test to PD 4.0.0 migration function #5374

Closed
IanLondon opened this issue Apr 6, 2020 · 1 comment
Closed

Add unit test to PD 4.0.0 migration function #5374

IanLondon opened this issue Apr 6, 2020 · 1 comment
Labels
blocked Ticket or PR is blocked by other work

Comments

@IanLondon
Copy link
Contributor

Overview

This will already be covered in E2E from #5369 but I wanted to add unit test coverage to 4_0_0.js migration.

This is a broken-out follow-up to #5373, I didn't want to do it there b/c #5369 is going to move the fixtures all around

@IanLondon IanLondon added the blocked Ticket or PR is blocked by other work label Apr 6, 2020
@IanLondon
Copy link
Contributor Author

This should be size 1 but is tricky due to labware definitions getting mocked out in jest, so need to find a solution to that so protocol in matches protocol out for a given labware load name

@Kadee80 Kadee80 closed this as completed Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Ticket or PR is blocked by other work
Projects
None yet
Development

No branches or pull requests

2 participants