feat(protocol-designer): add PD Pause form migration for 3.0.x -> 4.0.0 #5373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanLondon
added
ready for review
protocol designer
shlokamin
reviewed
Apr 6, 2020
| const PAUSE_ACTION_MAP = { | ||
| true: 'untilTime', | ||
| false: 'untilResume', | ||
| } |
There was a problem hiding this comment.
Previously if pauseForAmountOfTime was true, I assume that always also meant that there would be at least one of pauseSecond, pauseMinute, or ``pauseHour`, right?
There was a problem hiding this comment.
should be, unless somehow the user was allowed to save an invalid form in some previous version of PD. But I figured this mapping was more direct/small/simple
Codecov Report
@@ Coverage Diff @@
## edge #5373 +/- ##
==========================================
- Coverage 63.71% 63.69% -0.02%
==========================================
Files 1087 1088 +1
Lines 30853 30865 +12
==========================================
+ Hits 19658 19661 +3
- Misses 11195 11204 +9
Continue to review full report at Codecov.
|
shlokamin
approved these changes
Apr 6, 2020
Kadee80
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
Closes #5371
Previously in 3.0.x (eg last release)
pauseForAmountOfTimehad valuestrueorfalse.This PR changes the
pauseForAmountOfTimefield topauseAction, and its values are the 3 we have in edge PD rn: untilResume, untilTime, and untilTemperature.changelog
2 commits:
review requests
NOTE! I want to write a unit test for
4_0_0.js, but I just moved the fixtures all around in #5369 so I want to add unit tests in after that is merged, as a follow-up. Will make ticket.risk assessment
PD only