Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PD: migrate Pause forms 3.0.x -> 4.0.0 #5371

Closed
IanLondon opened this issue Apr 6, 2020 · 0 comments · Fixed by #5373
Closed

PD: migrate Pause forms 3.0.x -> 4.0.0 #5371

IanLondon opened this issue Apr 6, 2020 · 0 comments · Fixed by #5373
Labels
protocol designer Affects the `protocol-designer` project
Milestone
SPDDRS Sprint 6

Comments

@IanLondon
Copy link
Contributor

IanLondon commented Apr 6, 2020 •
edited
Loading

Overview

These versioning numbers are getting weird b/c PD used to only export protocols with 1 schema number, but now is cross-compatible with v3 and v4.

PD when dealing with v3 protocols is now effectively v3.1.x, because the Pause form values have changed to support additional options. (PD I thought we decided to not change the existing values to avoid a migration??)

This means that PD needs a migration from 3.0 to 4, mapping the old Pause form values to new values.

Also I made #5369 without being aware this was going on, so those snapshots need to be updated b/c right now they're snapshots of an incomplete migration. IMO that can happen in this ticket or in that one, whatever's more expedient.

But PD version bump to 4.0.0 #5148 is a blocker to this, because migration functions depend on that number

Current behavior

  • Import a pre-modules-in-PD protocol with Pause steps, eg protocol-designer/src/load-file/__tests__/fixtures/throughMigrationV0/preFlexGrandfatheredProtocol.json
  • You'll see a timeline error: "Must either pause for amount of time, until told to resume, or until temperature reached"

Expected behavior

Pause should be migrated to the new values so that whatever was in the existing protocol maps to the new values
@IanLondon IanLondon added protocol designer Affects the `protocol-designer` project 🕷️ SPDDRS labels Apr 6, 2020
This was referenced Apr 6, 2020
Merged
Merged
@Kadee80 Kadee80 added this to the SPDDRS Sprint 6 milestone Apr 6, 2020
IanLondon added a commit that referenced this issue Apr 6, 2020
@IanLondon
feat(protocol-designer): add PD Pause form migration for 3.0.x -> 4.0…
e3ce552 
….0 (#5373)

* add migration 3.0.x -> 4.0.0 to fix pause values (pauseForAmountOfTime -> pauseAction)

Closes #5371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
protocol designer Affects the `protocol-designer` project
Projects
None yet
Milestone
SPDDRS Sprint 6
Development

Successfully merging a pull request may close this issue.

feat(protocol-designer): add PD Pause form migration for 3.0.x -> 4.0.0 Opentrons/opentrons
2 participants
@Kadee80 @IanLondon