Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds specified versions for jupyter dependencies #1204

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

Laura-Danielle
Copy link
Contributor

overview

Forces library packages tornado and zmq to be compatible versions (i.e. 4.5.1 and 16.0.2 respectively). See issue jupyter/notebook#3407. Fixes #1066 .

changelog

  • Forces the versions of jupyter, tornado, pyzmq in the docker file
  • Tested in the devbots application, moved one robot over from a separate application that
    had a broken jupyter notebook and it was also successful.

review requests

@Laura-Danielle Laura-Danielle requested review from mcous and btmorr April 16, 2018 23:16
Copy link
Contributor

@btmorr btmorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️ Yeah!

@btmorr btmorr added container Affects the robot's Docker container bug fix PR fixes a bug and removed bug labels Apr 17, 2018
@Laura-Danielle Laura-Danielle force-pushed the api_bug-jupyter-dependencies branch from 963774d to d753748 Compare April 17, 2018 16:06
@codecov
Copy link

codecov bot commented Apr 17, 2018

Codecov Report

Merging #1204 into edge will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge    #1204   +/-   ##
=======================================
  Coverage   37.97%   37.97%           
=======================================
  Files         283      283           
  Lines        4324     4324           
=======================================
  Hits         1642     1642           
  Misses       2682     2682

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 215e81c...d753748. Read the comment docs.

@Laura-Danielle Laura-Danielle merged commit 9ef2727 into edge Apr 17, 2018
@Laura-Danielle Laura-Danielle deleted the api_bug-jupyter-dependencies branch April 17, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
container Affects the robot's Docker container fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants