Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(protocol-designer): add migration + load-save e2e tests #5369

Merged
merged 8 commits into from
Apr 8, 2020
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
146 changes: 146 additions & 0 deletions protocol-designer/cypress/integration/migrations.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,146 @@
import 'cypress-file-upload'
import cloneDeep from 'lodash/cloneDeep'
import { expectDeepEqual } from '../utils'

describe('Protocol fixtures migrate and match snapshots', () => {
beforeEach(() => {
cy.visit('/')
cy.closeAnnouncementModal()
})

const testCases = [
{
title: 'preFlexGrandfatheredProtocol 1.0.0 -> 4.0.x, schema 3',
importFixture:
'../../fixtures/protocol/1/preFlexGrandfatheredProtocol.json',
expectedExportFixture:
'../../fixtures/protocol/3/preFlexGrandfatheredProtocolMigratedFromV1_0_0.json',
newLabwareDefsMigrationModal: true,
unusedPipettes: false,
apiUpdateRequiredMigrationModal: false,
genericMigrationModal: false,
},
{
title: 'example_1_1_0 -> 4.0.x, schema 3',
importFixture: '../../fixtures/protocol/1/example_1_1_0.json',
expectedExportFixture:
'../../fixtures/protocol/3/example_1_1_0MigratedFromV1_0_0.json',
newLabwareDefsMigrationModal: true,
unusedPipettes: true,
apiUpdateRequiredMigrationModal: false,
genericMigrationModal: false,
},
{
title: 'doItAllV3 -> import and re-export should preserve data',
importFixture: '../../fixtures/protocol/3/doItAllV3.json',
expectedExportFixture: '../../fixtures/protocol/3/doItAllV3.json',
newLabwareDefsMigrationModal: false,
unusedPipettes: false,
apiUpdateRequiredMigrationModal: false,
genericMigrationModal: false,
},
{
title: 'doItAllV4 -> import and re-export should preserve data',
importFixture: '../../fixtures/protocol/4/doItAllV4.json',
expectedExportFixture: '../../fixtures/protocol/4/doItAllV4.json',
newLabwareDefsMigrationModal: false,
unusedPipettes: false,
apiUpdateRequiredMigrationModal: true,
genericMigrationModal: false,
},
]

testCases.forEach(
({
title,
importFixture,
expectedExportFixture,
newLabwareDefsMigrationModal,
unusedPipettes,
apiUpdateRequiredMigrationModal,
genericMigrationModal,
}) => {
it(title, () => {
cy.fixture(importFixture).then(fileContent => {
// TODO(IL, 2020-04-02): `cy.fixture` always parses .json files, though we want the plain text.
// So we have to use JSON.stringify. See https://github.com/cypress-io/cypress/issues/5395
// Also, the latest version v4 of cypress-file-upload is too implicit to allow us to
// use the JSON.stringify workaround, so we're stuck on 3.5.3,
// see https://github.com/abramenal/cypress-file-upload/issues/175
cy.get('input[type=file]').upload({
fileContent: JSON.stringify(fileContent),
fileName: 'fixture.json',
mimeType: 'application/json',
encoding: 'utf8',
})
})

if (genericMigrationModal) {
cy.get('div')
.contains(
'Your protocol was made in an older version of Protocol Designer'
)
.should('exist')
cy.get('button')
.contains('ok', { matchCase: false })
.click()
}

if (newLabwareDefsMigrationModal) {
// close migration announcement modal
cy.get('div')
.contains('Update protocol to use new labware definitions')
.should('exist')
cy.get('button')
.contains('update protocol', { matchCase: false })
.click()
}

cy.fixture(expectedExportFixture).then(expectedExportProtocol => {
cy.get('button')
.contains('Export')
.click()

if (unusedPipettes) {
cy.get('div')
.contains('Unused pipette')
.should('exist')
cy.get('button')
.contains('continue with export', { matchCase: false })
.click()
}

if (apiUpdateRequiredMigrationModal) {
cy.get('div')
.contains(
'Robot requirements for running module inclusive JSON protocols'
)
.should('exist')
cy.get('button')
.contains('continue', { matchCase: false })
.click()
}

cy.window().then(window => {
const savedFile = cloneDeep(window.__lastSavedFile__)
const expected = cloneDeep(expectedExportProtocol)

assert.match(
savedFile.designerApplication.version,
/^4\.0\.\d+$/,
'designerApplication.version is 4.0.x'
)
;[savedFile, expected].forEach(f => {
// Homogenize fields we don't want to compare
f.metadata.lastModified = 123
f.designerApplication.data._internalAppBuildDate = 'Foo Date'
f.designerApplication.version = 'x.x.x'
})

expectDeepEqual(savedFile, expected)
})
})
})
}
)
})
33 changes: 33 additions & 0 deletions protocol-designer/cypress/utils.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import isEqual from 'lodash/isEqual'
import isObject from 'lodash/isObject'
import transform from 'lodash/transform'

const difference = (object, base) => {
const changes = (object, base) => {
return transform(object, function(result, value, key) {
if (!isEqual(value, base[key])) {
result[key] =
isObject(value) && isObject(base[key])
? changes(value, base[key])
: value
}
})
}
return changes(object, base)
}

// deepEqual won't always return a diff, Cypress doesn't fully support object diffs :(
// also Cypress doesn't seem to support logging to the console? So throwing the diff as an error instead
Copy link
Contributor

@dozercodes dozercodes Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, really? I was able to log to console in one of my tests, so I'm not sure why it wouldn't work here
Edit: I misunderstood. This makes sense now.

export const expectDeepEqual = (a, b) => {
try {
assert.deepEqual(a, b)
} catch (e) {
// visualize undefineds
const replacer = (key, value) =>
typeof value === 'undefined' ? '__undefined__' : value
throw Error(
'Expected deep equal. Diff is: ' +
JSON.stringify(difference(a, b), replacer, 4)
)
}
}
Loading