-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#246 - Break Apart routes Module Into Package #247
#246 - Break Apart routes Module Into Package #247
Conversation
I just noticed there are conflicts, I guess my master branch was too old. That's a bummer. |
Yeah, and speaking of that, this is going to cause conflicts with probably every open PR that there is. We should probably consider a rollout strategy for this. Or at least wait to merge it until all of the currently open PRs are merged (though I don't want to block you indefinitely on the batch create one, I'll rebase that if I have to). I just don't want to break everyone else's WIP stuff |
What do you recommend? Should I start from scratch off of current master, or not? For selfish reasons, I'd like to get this brought in before Hacktoberfest is over. |
The rules of Hacktoberfest say that you need to open 4 PRs, not that those PRs need to be merged. If we need to let this sit into November that's fine. I wouldn't recommend opening the PR to break up the test_routes.py just yet, but you can open two other PRs to get them in for Hacktoberfest even while this one remains unmerged. If you need help deciding what else to open up, hit me up on slack, I have a couple ideas. |
You can also just submit a PR called Issue #XXX WIP. As long as the repo manager doesn't reject it or mark it as spam it should count as valid for Hactoberfest. |
Thanks @C-Lion; I'll just rebase when things settle down a bit. |
Retrying in #267. |
This also closes #246 |
This PR, as per the request in #246, breaks apart the routes module into a new package, where separate modules organized by functional area.