Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPHJOD-952: Update Accordion to work better with screenreader #175

Merged
merged 1 commit into from
Oct 30, 2024
Merged

OPHJOD-952: Update Accordion to work better with screenreader #175

merged 1 commit into from
Oct 30, 2024

Conversation

ketsappi
Copy link
Contributor

@ketsappi ketsappi commented Oct 29, 2024 •
edited
Loading

Description

  • Remove expandMoreText & expandLessText props
    • The aria-expanded gives this information to user when using screenreader
  • Update aria-label logic so that it works with both cases: when title is ReactNode or when it is just a string
  • Add new titleText prop which is required when title is not a string

Related JIRA ticket

https://jira.eduuni.fi/browse/OPHJOD-952

@ketsappi ketsappi requested review from juhaniko and sauanto October 29, 2024 10:46
@ketsappi ketsappi marked this pull request as draft October 29, 2024 10:50
@ketsappi ketsappi marked this pull request as ready for review October 29, 2024 12:46
@ketsappi ketsappi mentioned this pull request Oct 29, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ketsappi ketsappi merged commit dcd0d6b into main Oct 30, 2024
4 checks passed
@ketsappi ketsappi deleted the OPHJOD-952 branch October 30, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikuo henrikuo henrikuo approved these changes

@sauanto sauanto sauanto approved these changes

@juhaniko juhaniko Awaiting requested review from juhaniko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ketsappi @sauanto @henrikuo