OPHJOD-566: Add MediaCard component #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juhaniko
reviewed
Nov 4, 2024
|
|
||
| return ( | ||
| <LinkOrDiv to={to} linkComponent={Link} className={variantContainerClassNames}> | ||
| <img className={`${variantImageClassNames}`} src={imageSrc} alt=""></img> |
There was a problem hiding this comment.
Should there be an alt text? Also self closing tag would look nicer.
There was a problem hiding this comment.
Good finds. Changes are now committed regarding this.
ketsappi
force-pushed
the
OPHJOD-566
branch
2 times, most recently
from
bb37ac9 to
aa1efb1
Compare
|
juhaniko
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add MediaCard component.
Expecting to see adjustments when actually using the component later on.
Screenshots
Vertical
Horizontal
Related JIRA ticket
https://jira.eduuni.fi/browse/OPHJOD-566