Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPHJOD-1009: Update outdated dependencies #182

Merged
merged 2 commits into from
Nov 8, 2024
Merged

OPHJOD-1009: Update outdated dependencies #182

merged 2 commits into from
Nov 8, 2024

Conversation

juhaniko
Copy link
Contributor

@juhaniko juhaniko commented Nov 7, 2024

Description

Updated the following packages reported by npm outdated:

  • @testing-library/react
  • @vitest/coverage-v8
  • jsdom
  • vite-plugin-dts
  • vitest

ESLint and Prettier package updates were not straightforward so their changes are in a separate commit in this PR

Updated packages:

  • @typescipt-eslint/parser
  • @typescipt-eslint/eslint-plugin
  • eslint
  • eslint-plugin-react-hooks
  • eslint-plugin-sonarjs
  • prettier-plugin-organize-import
  • prettier-plugin-tailwindcss

sonarjs plugin had a big version bump from 0.24.0 to 2.0.4 which introduced many issues that had to be fixed.

ESLInt latest version is 9.x.x, but it wasn't possible to update since @typescript-eslint packages don't support it yet.

Tested each component in storybook, all worked as intended.

Other changes:

  • There was an error in Checkbox tests, vi.fn should be vi.fn(). I wonder why it worked before 🤷
  • In SelectionCard, use useState from storybook instead of React to avoid error in storybook while rendering the component.

Related JIRA ticket

https://jira.eduuni.fi/browse/OPHJOD-1009
https://jira.eduuni.fi/browse/OPHJOD-1024

@juhaniko juhaniko requested a review from sauanto November 7, 2024 12:25
Copy link

sonarqubecloud bot commented Nov 8, 2024

@juhaniko juhaniko merged commit 7636dff into main Nov 8, 2024
4 checks passed
@juhaniko juhaniko deleted the OPHJOD-1009 branch November 8, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants