Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPHJOD-1200: Update dependencies #209

Merged
merged 1 commit into from
Jan 17, 2025
Merged

OPHJOD-1200: Update dependencies #209

merged 1 commit into from
Jan 17, 2025

Conversation

ketsappi
Copy link
Contributor

@ketsappi ketsappi commented Jan 16, 2025

Description

Update dependencies

Additional notes

If updating any of these to 8.5.0 in package.json

    "@storybook/react": "^8.4.7",
    "@storybook/react-vite": "^8.4.7",
    "@storybook/test": "^8.4.7",

The following errors arrived:

❯ npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @jod/design-system@0.0.0
npm ERR! Found: @storybook/react@8.4.7
npm ERR! node_modules/@storybook/react
npm ERR!   dev @storybook/react@"^8.5.0" from the root project
npm ERR!   @storybook/react@"8.4.7" from @storybook/react-vite@8.4.7
npm ERR!   node_modules/@storybook/react-vite
npm ERR!     dev @storybook/react-vite@"^8.4.7" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! dev @storybook/react@"^8.5.0" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @storybook/test@8.5.0
npm ERR! node_modules/@storybook/test
npm ERR!   peerOptional @storybook/test@"8.5.0" from @storybook/react@8.5.0
npm ERR!   node_modules/@storybook/react
npm ERR!     dev @storybook/react@"^8.5.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

It seems to be possible to install these when using force npm i --force, but did not yet do it.

Related JIRA ticket

https://jira.eduuni.fi/browse/OPHJOD-1200
https://jira.eduuni.fi/browse/OPHJOD-851

@ketsappi ketsappi merged commit d7c2f59 into main Jan 17, 2025
5 checks passed
@ketsappi ketsappi deleted the OPHJOD-1200 branch January 17, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants