Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Argo app created to be logged in backend, ux issues in status screen #18

Merged
merged 1 commit into from
Feb 7, 2024
Merged

feat:Argo app created to be logged in backend, ux issues in status screen #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/app/applications/components/application-create-panel/application-create-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export const ApplicationCreatePanel = (props: {
}>
{({projects, clusters, reposInfo}) => {
if (pathHasOpsmx) {
window.parent.postMessage({msg:'loadEvent'},'*');
window.parent.postMessage(window.btoa(JSON.stringify({msg:'loadEvent'})),'*')
}
const repos = reposInfo.map(info => info.repo).sort();
const app = deepMerge(DEFAULT_APP, props.app || {});
Expand Down
6 changes: 3 additions & 3 deletions ui/src/app/applications/components/applications-list/applications-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ export const ApplicationsList = (props: RouteComponentProps<{}>) => {
isShown={!!appInput}
onClose={() => {
if(pathHasOpsmx){
window.parent.postMessage({msg:'closeEvent'},'*')
window.parent.postMessage(window.btoa(JSON.stringify({msg:'closeEvent'})),'*')
}
ctx.navigation.goto('.', {new: null}, {replace: true})}}
header={
Expand All @@ -603,7 +603,7 @@ export const ApplicationsList = (props: RouteComponentProps<{}>) => {
qe-id='applications-list-button-cancel'
onClick={() => {
if(pathHasOpsmx){
window.parent.postMessage({msg:'closeEvent'},'*')
window.parent.postMessage(window.btoa(JSON.stringify({msg:'closeEvent'})),'*')
}
ctx.navigation.goto('.', {new: null}, {replace: true})}}
className='argo-button argo-button--base-o'>
Expand All @@ -622,7 +622,7 @@ export const ApplicationsList = (props: RouteComponentProps<{}>) => {
await services.applications.create(app);
//iframe msg alert needed
if(pathHasOpsmx){
window.parent.postMessage({msg:'saveEvent'},'*')
window.parent.postMessage(window.btoa(JSON.stringify({msg:'saveEvent',appName:app['metadata']['name']})),'*')
}
ctx.navigation.goto('.', {new: null}, {replace: true});
} catch (e) {
Expand Down
2 changes: 1 addition & 1 deletion ui/src/app/applications/components/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export async function deleteApplication(appName: string, appNamespace: string, a
}
}
},
{name: 'argo-icon-warning', color: 'info'},
{name: 'argo-icon-warning', color: ''},
'',
{propagationPolicy: 'foreground'}
);
Expand Down
2 changes: 1 addition & 1 deletion ui/src/app/sidebar/sidebar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
color: white;
background-color: $silver-lining;
overflow: auto;
z-index: 0;
z-index: 0 !important;

&__logo {
justify-content: center;
Expand Down
Loading