Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #101

Closed
wants to merge 2 commits into from
Closed

Update README.md #101

wants to merge 2 commits into from

Conversation

girichinna27
Copy link
Collaborator

We prefer small, well tested pull requests.

Please refer to Contributing to Spinnaker.

When filling out a pull request, please consider the following:

  • Follow the commit message conventions found here.
  • Provide a descriptive summary for your changes.
  • If it fixes a bug or resolves a feature request, be sure to link to that issue.
  • Add inline code comments to changes that might not be obvious.
  • Squash your commits as you keep adding changes.
  • Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.

@gopaljayanthi
Copy link
Collaborator

This PR is rejected because reference to JIra ticket does not exist in the comments section of this PR. Reviewers approve only after jira reference is added.

@gopaljayanthi
Copy link
Collaborator

This PR triggered this build in this execution, please merge to master only if this succeeds: https://spin.prod.opsmx.com/#/applications/gcp-gitprtrigger/executions/details/01FQGW76SKKHGF8QXKD41PF50B

@gopaljayanthi
Copy link
Collaborator

This PR is rejected because reference to JIra ticket does not exist in the comments section of this PR. Reviewers approve only after jira reference is added.

@gopaljayanthi
Copy link
Collaborator

This PR triggered this build in this execution, please merge to master only if this succeeds: https://spin.prod.opsmx.com/#/applications/gcp-gitprtrigger/executions/details/01FQGWBRD71E3XFHBCW6W418MG

@girichinna27 girichinna27 deleted the girichinna27-patch-3 branch June 13, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants