Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-12395 : Feature : Authentication Flag For AgentOnBoarding APIs (Apple Automation) #146

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

rsh09
Copy link

@rsh09 rsh09 commented Feb 21, 2022

https://devopsmx.atlassian.net/browse/OP-12395

We prefer small, well tested pull requests.

Please refer to Contributing to Spinnaker.

When filling out a pull request, please consider the following:

  • Follow the commit message conventions found here.
  • Provide a descriptive summary for your changes.
  • If it fixes a bug or resolves a feature request, be sure to link to that issue.
  • Add inline code comments to changes that might not be obvious.
  • Squash your commits as you keep adding changes.
  • Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.

@gopaljayanthi
Copy link
Collaborator

This PR triggered this build in this execution, please merge to v3.11 branch only if this succeeds: https://spin.prod.opsmx.com/#/applications/isd311/executions/details/01FWEBKWY3EYERM0NZXG79ZMCE

@Pranav-b-7 Pranav-b-7 merged commit 4e70e71 into v3.11 Feb 24, 2022
@Pranav-b-7 Pranav-b-7 deleted the OP-12395-V3.11 branch February 24, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants