Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accountId request param added in delete api #20

Merged
merged 3 commits into from
Jul 8, 2021
Merged

accountId request param added in delete api #20

merged 3 commits into from
Jul 8, 2021

Conversation

Pranav-b-7
Copy link

We prefer small, well tested pull requests.

Please refer to Contributing to Spinnaker.

When filling out a pull request, please consider the following:

  • Follow the commit message conventions found here.
  • Provide a descriptive summary for your changes.
  • If it fixes a bug or resolves a feature request, be sure to link to that issue.
  • Add inline code comments to changes that might not be obvious.
  • Squash your commits as you keep adding changes.
  • Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.

https://devopsmx.atlassian.net/browse/OP-6834

@Pranav-b-7 Pranav-b-7 requested a review from sudhakaropsmx July 8, 2021 07:20
@opsmxuser
Copy link
Collaborator

This PR triggered this build in this execution, please merge to master only if this succeeds: https://spin.prod.opsmx.com/#/applications/gitprtrigger/executions/details/01FA2FV1MN85CGVVB88CPC30TD

@opsmxuser
Copy link
Collaborator

This PR triggered this build in this execution, please merge to master only if this succeeds: https://spin.prod.opsmx.com/#/applications/gitprtrigger/executions/details/01FA2H7CDJPNNDN2M7V0AQJTJW

@opsmxuser
Copy link
Collaborator

RunTestJar RESULT: Total tests run: 276, Failures: 2, Skips: 0 Reviewers , please check that the changes in this PR did not cause the failures in http://jenkins.opsmx.net:8181/jenkins/job/Dev-run-tests-on-gitpr-parallel/ws/emailable-report-571.html

@Pranav-b-7 Pranav-b-7 merged commit 32cd822 into master Jul 8, 2021
@Pranav-b-7 Pranav-b-7 deleted the OP-6834 branch July 8, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants