Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-15067: gate approval api #203

Merged
merged 1 commit into from
May 6, 2022
Merged

OP-15067: gate approval api #203

merged 1 commit into from
May 6, 2022

Conversation

ramyaravi-opsmx
Copy link

We prefer small, well tested pull requests.

Please refer to Contributing to Spinnaker.

When filling out a pull request, please consider the following:

  • Follow the commit message conventions found here.
  • Provide a descriptive summary for your changes.
  • If it fixes a bug or resolves a feature request, be sure to link to that issue.
  • Add inline code comments to changes that might not be obvious.
  • Squash your commits as you keep adding changes.
  • Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.

https://devopsmx.atlassian.net/browse/OP-15067

@ramyaravi-opsmx ramyaravi-opsmx requested a review from Pranav-b-7 May 6, 2022 13:17
@opsmxuser
Copy link
Collaborator

This PR triggered this build in this execution, please wait for it and child pipelines to succeed before merging: https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01G2CR8K43RSRMN772Y05EC4EQ

@opsmxuser
Copy link
Collaborator

This PR triggered this build in this execution, please merge to master only if this succeeds: https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01G2CR8W1JZHVT6HBATKA8EF6D

@Pranav-b-7 Pranav-b-7 merged commit 6a06982 into master May 6, 2022
@Pranav-b-7 Pranav-b-7 deleted the OP-15067_approval_list branch May 6, 2022 13:20
@opsmxuser
Copy link
Collaborator

SUCCESSFUL RunTests RESULT: Tests run: 204, Failures: 2, Errors: 0, Skipped: 5, Time elapsed: 269.019 sec <<< FAILURE! Reviewers , this PR did not cause the failures in https://jenkins.opsmx.net:8181/jenkins/job/Dev-run-tests-on-gitpr-parallel/ws/emailable-report-40.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants