OP-14834: invalidate session and throw SAMLAuthenticationException to redirect to auth entry point. #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * OP-14834: Check and update the token. * OP-14834: Updated logs and packages. * OP-14834: Only validates ExpiringUsernameAuthenticationToken. * OP-14834: Only validates ExpiringUsernameAuthenticationToken. * OP-14834: Added SamlAuthTokenUpdateFilter to the filter chain. * OP-14834: Added SamlAuthTokenUpdateFilter to the filter chain after basic auth filter. * OP-14834: redirect to logout * OP-14834: throw AccessDeniedException * OP-14834:redirect to /saml/login. * OP-14834:redirect to /saml/sso. * OP-14834: send html response * OP-14834: clear context * OP-14834: invalidate session * OP-14834: and then logout * OP-14834: clear context, invalidate session and redirect to log out url. * OP-14834: invalidate session and throw SAMLAuthenticationException * OP-14834: removed commented code. * OP-14834: Updated the log message. * OP-14834: Updated the certificate
rahul-chekuri
requested review from
Pranav-b-7,
ramyaravi-opsmx and
rakeshkrmeena
|
This PR triggered this build in this execution, please wait for it and child pipelines to succeed before merging: https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01G38S8444QSKSMNFTQ8D0659Z |
|
This PR triggered this build in this execution, please merge to master only if this succeeds: https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01G38S8C9VBGDDZVCXWKXSKT16 |
|
SUCCESSFUL RunTests RESULT: Tests run: 201, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 186.348 sec Reviewers , this PR did not cause the failures in https://jenkins.opsmx.net:8181/jenkins/job/Dev-run-tests-on-gitpr-parallel/ws/emailable-report-125.html |
Pranav-b-7
suggested changes
May 18, 2022
gate-saml/src/main/groovy/com/netflix/spinnaker/gate/security/saml/SamlSsoConfig.groovy
Show resolved
Hide resolved
gate-saml/src/main/groovy/com/netflix/spinnaker/gate/security/saml/SamlSsoConfig.groovy
Show resolved
Hide resolved
Pranav-b-7
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://devopsmx.atlassian.net/browse/OP-14834