Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-16538 op-16537 - Added autocomplete off in login page #223

Merged

Conversation

sahititarigoppula
Copy link
Collaborator

https://devopsmx.atlassian.net/browse/OP-16538
https://devopsmx.atlassian.net/browse/OP-16537

We prefer small, well tested pull requests.

Please refer to Contributing to Spinnaker.

When filling out a pull request, please consider the following:

  • Follow the commit message conventions found here.
  • Provide a descriptive summary for your changes.
  • If it fixes a bug or resolves a feature request, be sure to link to that issue.
  • Add inline code comments to changes that might not be obvious.
  • Squash your commits as you keep adding changes.
  • Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.

@opsmxuser
Copy link
Collaborator

This PR triggered this build in this execution, please wait for it and child pipelines to succeed before merging: https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01G73YV46ZCAPHSB97Y3BY18NR

@opsmxuser
Copy link
Collaborator

This PR triggered this build in this execution, please merge to v4.0 branch only if this succeeds: https://isd.prod.opsmx.net/deck/#/applications/isd40/executions/details/01G73YVCCVA7Q7AMRA97DR14M3

@Luthan95 Luthan95 merged commit 5b3530a into v4.0 Jul 4, 2022
@Luthan95 Luthan95 deleted the feature/op-16538-op-16537-autoCompleteVulnerabilityFix-4.0 branch July 4, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants