Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-17106: Added SamlSsoEventPublishConfig to update ApplicationEventPublisher #234

Merged
merged 13 commits into from
Aug 12, 2022

Conversation

rahul-chekuri
Copy link
Collaborator

@opsmxuser
Copy link
Collaborator

This PR triggered this build in this execution, please wait for it and child pipelines to succeed before merging: https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01GA6C8BYJ7C7NNRPXQB1D0F48

@opsmxuser
Copy link
Collaborator

This PR triggered this build in this execution, please merge to v4.0 branch only if this succeeds: https://isd.prod.opsmx.net/deck/#/applications/isd40/executions/details/01GA6C8Y2Y5XWHXA2HDRBFK7Q8

@opsmxuser
Copy link
Collaborator

RunTestJar RESULT: Tests run: 229, Failures: 14, Errors: 0, Skipped: 29, Time elapsed: 417.686 sec <<< FAILURE! Reviewers , please check that the changes in this PR did not cause the failures in http://jenkins.opsmx.net:8181/jenkins/job/Dev-API-Automation-Test-v4.0/ws/emailable-report-214.html

private void handleInteractiveAuthenticationSuccessEvent(AbstractAuthenticationEvent event) {
AbstractAuthenticationToken auth = (AbstractAuthenticationToken) event.getAuthentication();
String name = auth.getName();
AuditData data = new AuditData(name);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the name field is passed ? why is it so minimal.. I think it would be better to pass the roles and usernames

Copy link
Collaborator Author

@rahul-chekuri rahul-chekuri Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name we are passing here is the user name. We are not using anything else other than the name at usage insights. There is enough room to add more fields on a need basis.

@ramyaravi-opsmx ramyaravi-opsmx merged commit 9a119d0 into v4.0 Aug 12, 2022
@ramyaravi-opsmx ramyaravi-opsmx deleted the bugfix/OP-17106-4-0 branch August 12, 2022 05:35
rahul-chekuri pushed a commit that referenced this pull request Aug 16, 2022
OP-17106: Added SamlSsoEventPublishConfig to update ApplicationEventPublisher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants