-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OP-17106: Added SamlSsoEventPublishConfig to update ApplicationEventPublisher #234
Conversation
…o update ApplicationEventPublisher.
This PR triggered this build in this execution, please wait for it and child pipelines to succeed before merging: https://isd.prod.opsmx.net/deck/#/applications/gcp-gitprtrigger/executions/details/01GA6C8BYJ7C7NNRPXQB1D0F48 |
This PR triggered this build in this execution, please merge to v4.0 branch only if this succeeds: https://isd.prod.opsmx.net/deck/#/applications/isd40/executions/details/01GA6C8Y2Y5XWHXA2HDRBFK7Q8 |
RunTestJar RESULT: Tests run: 229, Failures: 14, Errors: 0, Skipped: 29, Time elapsed: 417.686 sec <<< FAILURE! Reviewers , please check that the changes in this PR did not cause the failures in http://jenkins.opsmx.net:8181/jenkins/job/Dev-API-Automation-Test-v4.0/ws/emailable-report-214.html |
private void handleInteractiveAuthenticationSuccessEvent(AbstractAuthenticationEvent event) { | ||
AbstractAuthenticationToken auth = (AbstractAuthenticationToken) event.getAuthentication(); | ||
String name = auth.getName(); | ||
AuditData data = new AuditData(name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the name field is passed ? why is it so minimal.. I think it would be better to pass the roles and usernames
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name we are passing here is the user name. We are not using anything else other than the name at usage insights. There is enough room to add more fields on a need basis.
OP-17106: Added SamlSsoEventPublishConfig to update ApplicationEventPublisher
https://devopsmx.atlassian.net/browse/OP-17106