Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make clipping masks work with Move tool and offset image dialog #1057

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Make clipping masks work with Move tool and offset image dialog #1057

merged 3 commits into from
Jul 30, 2024

Conversation

Variable-ind
Copy link
Contributor

clip-.4.mp4

OverloadedOrama
OverloadedOrama approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should find a way to not replicate the blend_layers method since a very similar method already exists in DrawingAlgos.gd, so perhaps we could re-write that somehow, but we could look into this for the future. Thank you!

@OverloadedOrama OverloadedOrama merged commit 1d82bd9 into Orama-Interactive:master Jul 30, 2024
3 of 4 checks passed
@Variable-ind Variable-ind deleted the cliping-fix branch August 1, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OverloadedOrama OverloadedOrama OverloadedOrama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Variable-ind @OverloadedOrama