Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recorder extension to core #823

Merged
merged 8 commits into from
Mar 7, 2023
Merged

Recorder extension to core #823

merged 8 commits into from
Mar 7, 2023

Conversation

Variable-ind
Copy link
Contributor

Recorder.mp4

OverloadedOrama
OverloadedOrama approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@OverloadedOrama OverloadedOrama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I wonder if we could call ffmpeg to automatically convert the images to a video, but I suppose we'd first need to check if the user has ffmpeg installed. But for now this should be fine. Thank you!

@OverloadedOrama OverloadedOrama merged commit d9efe97 into Orama-Interactive:master Mar 7, 2023
@Variable-ind Variable-ind deleted the recorder branch March 14, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OverloadedOrama OverloadedOrama OverloadedOrama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Variable-ind @OverloadedOrama