Remarks in // or 

Orange-OpenSource · May 23, 2022 · e31014f · e31014f
1 parent c47350d
commit e31014f
Show file tree

Hide file tree

Showing 10 changed files with 23 additions and 99 deletions.
diff --git a/scss/_navbar.scss b/scss/_navbar.scss
@@ -455,7 +455,7 @@
 
         //////////////////////////////////////////////////////////////////////////////
         //////////////////////////////////////////////////////////////////////////////
-        // TODO: Is it really useful in Boosted?
+        // TODO: Is it really useful in Boosted? - LMP: I would to have better Bootstrap compatibility ? However, doesn't change anything IMO
         //////////////////////////////////////////////////////////////////////////////
         //////////////////////////////////////////////////////////////////////////////
         .offcanvas {

diff --git a/site/assets/js/code-examples.js b/site/assets/js/code-examples.js
@@ -18,13 +18,6 @@
   const btnTitle = 'Copy to clipboard'
   const btnEdit = 'Edit on StackBlitz'
 
-  // ////////////////////////////////////////////////////////
-  // ////////////////////////////////////////////////////////
-  // TODO: Bootstrap can remove width, height and
-  // fill="currentColor" of <svg class="bi"... since ".bi"
-  // already does that
-  // ////////////////////////////////////////////////////////
-  // ////////////////////////////////////////////////////////
   // Boosted mod: removed unused svg height, width and fill="currentColor"
   const btnHtml = [
     '<div class="bd-code-snippet">',

diff --git a/site/assets/scss/_clipboard-js.scss b/site/assets/scss/_clipboard-js.scss
@@ -29,7 +29,7 @@
 
   ////////////////////////////////////////////////////////
   ////////////////////////////////////////////////////////
-  // TODO: see if we can't use a btn-* class instead
+  // TODO: see if we can't use a btn-* class instead - LMP: Check comments, but IMO hard to do
   ////////////////////////////////////////////////////////
   ////////////////////////////////////////////////////////
   &:hover {
@@ -51,24 +51,10 @@
 .btn-clipboard {
   position: relative;
   z-index: 2;
-  ////////////////////////////////////////////////////////
-  ////////////////////////////////////////////////////////
-  // TODO: check all cases
-  // TODO: see if we can't use $border-something
-  // TODO: px >>> rem
-  ////////////////////////////////////////////////////////
-  ////////////////////////////////////////////////////////
-  margin-top: 2px; // Boosted mod
-  margin-right: 2px; // Boosted mod
+  margin-top: $border-width; // Boosted mod
+  margin-right: $border-width; // Boosted mod
 }
 
-////////////////////////////////////////////////////////
-////////////////////////////////////////////////////////
-// Boosted mod: removed it in favor of using utility classes
-// in shortcodes > example.html
-////////////////////////////////////////////////////////
-////////////////////////////////////////////////////////
-
 /* .highlight-toolbar {
   .btn-clipboard {
     margin-top: 0;

diff --git a/site/assets/scss/_content.scss b/site/assets/scss/_content.scss
@@ -101,11 +101,6 @@
   fill: currentcolor;
 }
 
-/////////////////////////////////////////////////////////////////
-/////////////////////////////////////////////////////////////////
-// TODO: test into Bootstrap if there's not a conflict with .icon-link in features.css
-/////////////////////////////////////////////////////////////////
-/////////////////////////////////////////////////////////////////
 .icon-link {
   display: flex;
   align-items: center;
@@ -121,7 +116,7 @@
 
   /////////////////////////////////////////////////////////////////
   /////////////////////////////////////////////////////////////////
-  // TODO: Do we keep this animation in Boosted?
+  // TODO: Do we keep this animation in Boosted? - LMP: IMO, make the homepage a bit more attractive
   /////////////////////////////////////////////////////////////////
   /////////////////////////////////////////////////////////////////
   &:hover {

diff --git a/site/assets/scss/_layout.scss b/site/assets/scss/_layout.scss
@@ -1,8 +1,3 @@
-///////////////////////////////////////////////
-///////////////////////////////////////////////
-// TODO: check me! Not sure what's the purpose of --bs-gutter-x
-///////////////////////////////////////////////
-///////////////////////////////////////////////
 .bd-gutter {
   --bs-gutter-x: #{$bd-gutter-x * 2};
 

diff --git a/site/assets/scss/_masthead.scss b/site/assets/scss/_masthead.scss
@@ -71,10 +71,4 @@
   }
 }
 
-///////////////////////////////////////////////////////////
-///////////////////////////////////////////////////////////
-// Boosted mod: no .masthead-followup-svg
 // Boosted mod: no .masthead-notice
-// TODO: check if it's the case in Bootstrap as well
-///////////////////////////////////////////////////////////
-///////////////////////////////////////////////////////////
diff --git a/site/assets/scss/_navbar.scss b/site/assets/scss/_navbar.scss
@@ -1,37 +1,22 @@
-/////////////////////////////////////////////////////////////////////////////////
-/////////////////////////////////////////////////////////////////////////////////
-// TODO: check all those rules but normally we wouldn't need anything in this file
-/////////////////////////////////////////////////////////////////////////////////
-/////////////////////////////////////////////////////////////////////////////////
 .bd-navbar {
   // Boosted mod: no padding
-  background-color: transparent;
+  // Boosted mod: no background-color
   // Boosted mod: no background-image
   // Boosted mod: no box-shadow
 
-  // Boosted mod: no .navbar-toggler
-
-  // Boosted mod
-  .navbar-nav.flex-row {
-    @include media-breakpoint-down(lg) {
-      border-top: 1px solid #666;
-    }
-  }
-  // End mod
-
   // Boosted mod: no .navbar-brand
 
-  .navbar-toggler,
-  .nav-link {
-    display: block; // Boosted mod: no padding, no color
+  // Boosted mod: no .navbar-toggler
+  .nav-link { // Boosted mod: Needed since the dropdowns define their own color (could be removed once they are tackled)
+    // Boosted mod: no display, no padding, no color
 
     &:hover,
     &:focus {
       color: var(--#{$prefix}link-hover-color); // Boosted mod
     }
 
     &.active {
-      font-weight: 600;
+      // Boosted mod: no font-weight
       color: var(--#{$prefix}link-hover-color); // Boosted mod
     }
   }
@@ -56,4 +41,12 @@
     background-position: right $dropdown-item-padding-x top .75rem; // Boosted mod
     background-size: .75rem .75rem;
   }
+
+  // Boosted mod: Specificity
+  .navbar-nav.flex-row {
+    @include media-breakpoint-down(lg) {
+      border-top: 1px solid #666;
+    }
+  }
+  // End mod
 }
diff --git a/site/assets/scss/_sidebar.scss b/site/assets/scss/_sidebar.scss
@@ -35,12 +35,7 @@
 .bd-links-link {
   padding: .1875rem .5rem;
   margin-top: .125rem;
-  //////////////////////////////////////////////////////////////////////////////
-  //////////////////////////////////////////////////////////////////////////////
-  // TODO: adapt this rule after having changed the size of icons
-  //////////////////////////////////////////////////////////////////////////////
-  //////////////////////////////////////////////////////////////////////////////
-  margin-left: 1.125rem; // Boosted mod: changed value
+  margin-left: 1.375rem; // Boosted mod: changed value
   color: rgba($black, .65);
   text-decoration: if($link-decoration == none, null, none);
 
@@ -52,11 +47,7 @@
 }
 
 // Boosted mod
-.bd-links-heading {
-  transform: translateX(-#{$spacer * .25});
-
-  svg {
-    font-size: 1.5625rem;
-  }
+.bd-links-heading svg {
+  font-size: 1.5625rem;
 }
 // End mod
diff --git a/site/layouts/partials/docs-subnav.html b/site/layouts/partials/docs-subnav.html
@@ -5,9 +5,7 @@
     <button class="btn btn-secondary btn-icon p-2" type="button" data-bs-toggle="offcanvas" data-bs-target="#bdSidebar" aria-controls="bdSidebar" aria-expanded="false" aria-label="Toggle docs navigation">
       <!--------------------------------------------------------------->
       <!--------------------------------------------------------------->
-      <!--------------------------------------------------------------->
-      <!-- TODO: choose the right icon from icons.html, use it with its class and change the size -->
-      <!--------------------------------------------------------------->
+      <!-- TODO: choose the right icon from icons.html, use it with its class and change the size - LMP: Didn't find any, ask to design ? -->
       <!--------------------------------------------------------------->
       <!--------------------------------------------------------------->
       <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" class="bi" fill="currentColor" viewBox="0 0 16 16">

diff --git a/site/layouts/shortcodes/example.html b/site/layouts/shortcodes/example.html
@@ -26,38 +26,17 @@
     {{- if eq $show_preview true -}}
       <!---------------------------------------------------->
       <!---------------------------------------------------->
-      <!---------------------------------------------------->
-      <!--Boosted mod: remove extra space-->
-      <!-- >> to Bootstrap -->
-      <!--Boosted mod: used .align-items-baseline instead of .align-items-center-->
+      <!--Boosted mod: used .align-items-baseline instead of .align-items-center--> <!--Not sure what's the purpose here-->
       <!-- >> to Bootstrap -->
       <!---------------------------------------------------->
       <!---------------------------------------------------->
-      <!---------------------------------------------------->
       <!--Boosted mod: removed .bg-light -->
       <div class="d-flex align-items-baseline highlight-toolbar ps-3 pe-2 py-1">
         <small class="font-monospace text-muted text-uppercase">{{- $lang -}}</small>
         <div class="d-flex ms-auto">
-          <!---------------------------------------------------->
-          <!---------------------------------------------------->
-          <!---------------------------------------------------->
-          <!-- Boosted mod: removed width, height, fill -->
-          <!-- TODO: propose it to Bootstrap -->
-          <!-- TODO: lightning aria-label shouldn't be Copy! >>> Bootstrap -->
-          <!---------------------------------------------------->
-          <!---------------------------------------------------->
-          <!---------------------------------------------------->
           <button type="button" class="btn-edit text-nowrap" title="Try it on StackBlitz">
             <svg class="bi" role="img" aria-label="Copy"><use xlink:href="#lightning-charge-fill"/></svg>
           </button>
-          <!---------------------------------------------------->
-          <!---------------------------------------------------->
-          <!---------------------------------------------------->
-          <!-- Boosted mod: added mt-0 me-0 classes -->
-          <!-- TODO: propose it to Bootstrap -->
-          <!---------------------------------------------------->
-          <!---------------------------------------------------->
-          <!---------------------------------------------------->
           <button type="button" class="btn-clipboard mt-0 me-0" title="Copy to clipboard">
             <svg class="bi" role="img" aria-label="Copy"><use xlink:href="#clipboard"/></svg>
           </button>