Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting dark dropdowns #1021

Merged
merged 6 commits into from
Feb 23, 2022
Merged

Adjusting dark dropdowns #1021

merged 6 commits into from
Feb 23, 2022

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jan 5, 2022

Description

Changed the variables associated with dark-dropdowns + update the associated template

Motivation & Context

Dark components

Types of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Related issues

Linked to #917.

Live preview

Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@julien-deramond julien-deramond merged commit 2f5ab48 into main Feb 23, 2022
@julien-deramond julien-deramond deleted the main-lmp-dark-dropdowns branch February 23, 2022 09:04
@julien-deramond julien-deramond mentioned this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants