chore/merge-main@795167d #1247
Merged
chore/merge-main@795167d #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,7 +27,7 @@ Badges can be used as part of links or buttons to provide a counter. | |||
|
|
|||
| {{< example >}} | |||
| <button type="button" class="btn btn-primary"> | |||
| Notifications <span class="badge bg-secondary">4</span> | |||
| Notifications <span class="badge text-bg-secondary">4</span> | |||
There was a problem hiding this comment.
Do we need to change the positionned example or not ?
There was a problem hiding this comment.
There is something I don't really understand in Bootstrap's modification. They use here .text-bg-secondary but the default value is already white. Two options:
- Remove the default color of badge with the CSS var and use everywhere in all examples
text-bg-* - Don't use here
.text-bg-secondarybecause it doesn't bring anything
Thoughts?
louismaximepiton
requested changes
May 12, 2022
|
|
||
| <div class="offcanvas-lg offcanvas-end" tabindex="-1" id="offcanvasResponsive" aria-labelledby="offcanvasResponsiveLabel"> | ||
| <div class="offcanvas-header"> | ||
| <h5 class="offcanvas-title" id="offcanvasResponsiveLabel">Responsive offcanvas</h5> | ||
| <button type="button" class="btn-close" data-bs-dismiss="offcanvas" aria-label="Close"></button> | ||
| <button type="button" class="btn-close" data-bs-dismiss="offcanvas" data-bs-target="#offcanvasResponsive"><span class="visually-hidden">Close</span></button> |
There was a problem hiding this comment.
Why do we need explicit target on this one and not on the others ?
There was a problem hiding this comment.
Without it:
Uncaught TypeError: this._config is undefined
_initializeBackDrop offcanvas.js:179
Offcanvas offcanvas.js:71
getOrCreateInstance base-component.js:65
I haven't looked at it in details but I find it weird. This is maybe a bug. Is it mentioned in the PR?
|
|
||
| Scrollspy also works with nested `.nav`s. If a nested `.nav` is `.active`, its parents will also be `.active`. Scroll the area next to the navbar and watch the active class change. | ||
|
|
||
| <div class="bd-example"> | ||
| <div class="row"> | ||
| <div class="col-4 col-lg-3"> | ||
| <nav id="navbar-example3" class="navbar flex-column align-items-stretch"> |
There was a problem hiding this comment.
This is not backported just below l.178
There was a problem hiding this comment.
Bootstrap side
louismaximepiton
requested changes
May 13, 2022
louismaximepiton
approved these changes
May 13, 2022
Merged
77 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.border-rightrule from modal example CSS file twbs/bootstrap#36328added: "5.1"and/oradded: "5.2"on top of new Markdown files in Boostedrole="group""Skip to main content" has been lost in the way