Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Submit buttons spacing #1495

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Docs: Submit buttons spacing #1495

merged 3 commits into from
Nov 9, 2022

Conversation

louismaximepiton
Copy link
Member

According to the pages in the DSM, Submit buttons should be 30px away from the last input.

@louismaximepiton louismaximepiton added v5 brand docs Improvements or additions to documentation labels Aug 29, 2022
@netlify
Copy link

netlify bot commented Aug 29, 2022 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit a7a095c
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/636ba1da519a9b00079569aa
😎 Deploy Preview https://deploy-preview-1495--boosted.netlify.app/docs/5.2/migration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

This was referenced Aug 29, 2022
Closed
Closed
@julien-deramond
Copy link
Member

This PR will need an explanation in the migration guide.

@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

julien-deramond
julien-deramond approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a not in the migration guide. The rest LGTM so 🚀

@julien-deramond julien-deramond merged commit 3db79a9 into main Nov 9, 2022
@julien-deramond julien-deramond deleted the main-lmp-submit-buttons-padding branch November 9, 2022 12:55
@julien-deramond julien-deramond mentioned this pull request Nov 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabellechanclou isabellechanclou isabellechanclou approved these changes

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
brand docs Improvements or additions to documentation v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@louismaximepiton @julien-deramond @isabellechanclou