Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y: remove some ambiguous links #1676

Closed
wants to merge 2 commits into from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Dec 2, 2022

Description

Remove Examples titles in order to be consistent in the whole doc + remove ambiguous links between the header and the ToC (search and replace # Examples to # Example).

Motivation & Context

Remove rectifiable issues raised by aXe devtools in the browser over the Boosted doc.

Types of change

  • Bug fix (non-breaking which fixes an issues)

Live previews

@netlify
Copy link

netlify bot commented Dec 2, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit e4a986f
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6389e5e58d5be500092ad387
😎 Deploy Preview https://deploy-preview-1676--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond

This comment was marked as resolved.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@louismaximepiton
Copy link
Member Author

Following gohugoio/hugo#10507, it seems like this isn't needed anymore since most of our links are inside a structure <ul><li></li></ul>. Furthermore it seems like the links with the same label aren't spotted anymore by aXeDevtools.

@louismaximepiton louismaximepiton deleted the main-lmp-ambiguous-links-fix branch February 7, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants