chore(merge main) patched commit → a1a9895 #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
julien-deramond
force-pushed
the
main-jd-merge-30-dec
branch
from
a440ad5 to
6958ea6
Compare
|
So I'm gonna tackle twbs/bootstrap@7cb376a + twbs/bootstrap@db60ae0 in a separate PR because it is complicated to modify and so probably to review |
julien-deramond
changed the title
louismaximepiton
requested changes
Jan 4, 2023
|
SonarCloud Quality Gate failed.
|
This was referenced Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First batch of commits to integrate into our main branch before Add dark mode support (which will be a dedicated PR) and then the commits after (in another dedicated PR right after).
twbs/bootstrap@bf6240d: nothing to do here because we don't have floating labelstwbs/bootstrap@01dc2f5: nothing to do here, this commit was already gathered for the v5.2.3twbs/bootstrap@8291746: nothing to do here, we don't have these examples in Boosted anymoretwbs/bootstrap@5029370: nothing to do here, this commit was already gathered for the v5.2.3twbs/bootstrap@4822984: nothing to do here, we don't have the cover example in Boostedtwbs/bootstrap@39bbca5: don't regeneratepackage-lock.jsonright nowtwbs/bootstrap@bbe1ffd: nothing to do here since our navbars example is different from Bootstrap's onetwbs/bootstrap@06bed9b: nothing to do here since we don't have floating labelstwbs/bootstrap@2b21094: nothing to do here, this commit was already gathered for the v5.2.3twbs/bootstrap@3e50a79: nothing to do here, the bundlewatch is already correct at this pointtwbs/bootstrap@8387827: nothing to do cause we don't have any codeql workflowtwbs/bootstrap@9aff4cd: nothing to do cause we don't have any codeql workflowtwbs/bootstrap@8576521: nothing to do here cause we don't have floating labels in BoostedIn this section, the commits are in fact a merge back from Bootstrap v5.2.3, so already gathered in commits before
twbs/bootstrap@b722369twbs/bootstrap@77c456dtwbs/bootstrap@127a816twbs/bootstrap@7e3074ctwbs/bootstrap@3958947twbs/bootstrap@cb02143twbs/bootstrap@8f6de23twbs/bootstrap@c139bactwbs/bootstrap@a1a9895: nothing to do cause we don't have the same navbars example in Boosted