Dark mode: form color #2278
Merged
Dark mode: form color #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismaximepiton
added
the
color mode
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hannahiss
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Juste 2 little observation:
- Just to be sure, I supposed it is due to browser, but in Chrome we have a border
#777around the purple, and not in FF - In Chrome, when the page is globally in light mode, when opening the picker, it has contextually a dark or light bg, depending on the component's theme. But when the page is globally in dark mode, picker always sticks to dark background. (supposed its due to the browser's implementation :-) )
Otherwise it looks good! If you approve both observations, I think you can merge!
Good catch! it should have come from Bootstrap merge commits we must have missed it. I've added it with b19be8c.
I wasn't aware of such a behavior. I think this should probably be tackled Bootstrap side with |
julien-deramond
approved these changes
Oct 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Form color in dark mode, by using existing and new Sass vars :
$form-color-border-colorvar(--#{$prefix}emphasis-color)$form-color-hover-bg-colorvar(--#{$prefix}emphasis-color)$form-color-disabled-bg-color$input-bg$form-color-disabled-border-color$gray-500var(--#{$prefix}disabled-color)$form-color-disabled-background-swatchbrightness(0) invert(1) brightness(.8)var(--#{$prefix}disabled-filter)--bs-disabled-filter(associated to$disabled-filterand$disabled-filter-dark. It renders the same value as--bs-disabled-color). Use it on icons or whatever to have the same rendering.Links