Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode: Form switch #2285

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Dark mode: Form switch #2285

merged 1 commit into from
Oct 25, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 6, 2023 •
edited by julien-deramond
Loading

Description

Form checks in dark mode, by using new Sass vars :

Sass var Previous value New value
$form-switch-square-bg - $black
$form-switch-bg - $white
$form-switch-border-color - $white
$form-switch-filter - var(--#{$prefix}input-filter)
$form-switch-focus-visible-inner - $black
$form-switch-focus-visible-outer - $white
$form-switch-checked-square-bg - var(--#{$prefix}highlight-color)
$form-switch-checked-bg - $primary
$form-switch-checked-border-color - $primary
$form-switch-checked-filter - none
$form-switch-checked-focus-inner - var(--#{$prefix}focus-visible-inner-color)
$form-switch-checked-focus-outer - var(--#{$prefix}focus-visible-outer-color)

⚠️ Make sure that the square inside is of the right color

Links

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Oct 6, 2023
@julien-deramond julien-deramond force-pushed the main-lmp-checks-radios-dark branch from 49bd416 to 1286d56 Compare October 10, 2023 06:10
@louismaximepiton louismaximepiton changed the base branch from main-lmp-checks-radios-dark to main-jd-dark-mode October 10, 2023 08:23
@louismaximepiton louismaximepiton marked this pull request as draft October 10, 2023 08:24
@julien-deramond julien-deramond marked this pull request as ready for review October 12, 2023 13:37
@netlify
Copy link

netlify bot commented Oct 12, 2023 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit f341cd5
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6538bdb5c2b85e0008f6decb
😎 Deploy Preview https://deploy-preview-2285--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

julien-deramond
julien-deramond suggested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, there's just a lil' issue to fix before merging. The background color in dark mode (the square without icon) should be #141414 instead of black.

@louismaximepiton louismaximepiton force-pushed the main-lmp-switch-dark branch 2 times, most recently from 34cdbfd to 0dcaacf Compare October 25, 2023 06:45
@louismaximepiton @julien-deramond
Add color mode on form switch
f341cd5 
Remove some break lines

.

Set all squares background to the right color for dark color mode

Add Black tweak
@julien-deramond julien-deramond merged commit 1dcca3d into main-jd-dark-mode Oct 25, 2023
13 checks passed
@julien-deramond julien-deramond deleted the main-lmp-switch-dark branch October 25, 2023 07:11
@julien-deramond julien-deramond mentioned this pull request Oct 25, 2023
Merged
julien-deramond pushed a commit that referenced this pull request Oct 26, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
506bd9d
julien-deramond pushed a commit that referenced this pull request Oct 31, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
e4089bd
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
cb3b4a7
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
8a5503b
julien-deramond pushed a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
477344a
julien-deramond pushed a commit that referenced this pull request Nov 6, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
e48cfb0
julien-deramond pushed a commit that referenced this pull request Nov 7, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
078cc50
julien-deramond pushed a commit that referenced this pull request Nov 8, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
86f4d4a
julien-deramond pushed a commit that referenced this pull request Nov 10, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
0b27d29
julien-deramond pushed a commit that referenced this pull request Nov 13, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
04a17eb
julien-deramond pushed a commit that referenced this pull request Nov 15, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
a3bf706
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
a4c269f
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
5095eac
julien-deramond pushed a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
46a2b98
julien-deramond pushed a commit that referenced this pull request Nov 29, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
b694fed
julien-deramond pushed a commit that referenced this pull request Nov 30, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
a72a6a1
julien-deramond pushed a commit that referenced this pull request Dec 1, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
75c5900
julien-deramond pushed a commit that referenced this pull request Dec 4, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
6bdc2fe
julien-deramond pushed a commit that referenced this pull request Dec 8, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
481ff0d
julien-deramond pushed a commit that referenced this pull request Dec 15, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
e3fa320
julien-deramond pushed a commit that referenced this pull request Dec 18, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
4956cf8
julien-deramond pushed a commit that referenced this pull request Dec 21, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
b684784
julien-deramond pushed a commit that referenced this pull request Dec 26, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
6762fa8
julien-deramond pushed a commit that referenced this pull request Dec 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
97f4ef4
julien-deramond pushed a commit that referenced this pull request Jan 2, 2024
@louismaximepiton @julien-deramond
Dark mode: Switches (#2285)
ca92d34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
color mode Temporary label to highlight color mode issues
Projects
🟣 [Orange-Boosted-Bootstrap] PRs Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louismaximepiton @julien-deramond