Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: Navs & tabs #2307

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Oct 12, 2023

Description

Navs & tabs in dark mode, by using existing Sass vars :

Sass var Previous value New value
$nav-tabs-link-hover-border-color $border-color var(--#{$prefix}highlight-color) ⚠️ strange use of this variable
$nav-underline-border-color $gray-500 var(--#{$prefix}border-color-translucent)
$nav-underline-link-active-color var(--#{$prefix}emphasis-color) var(--#{$prefix}hover-color)
$nav-underline-link-hover-color $accessible-orange var(--#{$prefix}link-hover-color) ⚠️ strange use of this variable
$nav-underline-link-active-bg var(--#{$prefix}body-bg) transparent ❓ do we need to keep these vars ? (only in Boosted)
$nav-underline-link-active-border-color $accessible-orange var(--#{$prefix}link-hover-color) ⚠️ strange use of this variable

⚠️ Added 2 Sass vars and corresponding css vars:

Sass var css var Value
$nav-tabs-link-hover-color --bs-nav-tabs-link-hover-color var(--#{$prefix}highlight-color)
$nav-tabs-link-hover-bg --bs-nav-tabs-link-hover-bg var(--#{$prefix}highlight-bg)

New CSS variable

--bs-tab-content-border-color in .nav-tabs

Links

@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 311de37
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6538b86ae84d250008a887e4
😎 Deploy Preview https://deploy-preview-2307--boosted.netlify.app/docs/5.3/dark-mode
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond added the color mode Temporary label to highlight color mode issues label Oct 12, 2023
@hannahiss hannahiss marked this pull request as ready for review October 12, 2023 13:53
scss/_variables.scss Outdated Show resolved Hide resolved
site/content/docs/5.3/dark-mode.md Outdated Show resolved Hide resolved
site/content/docs/5.3/dark-mode.md Outdated Show resolved Hide resolved
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I wasn't clear, but all ids mentionned here need a little shift. For instance:

  • tab2-content
  • tab3-content
  • tab4-content
  • linkB
  • linkC
  • linkD

site/content/docs/5.3/dark-mode.md Outdated Show resolved Hide resolved
site/content/docs/5.3/dark-mode.md Outdated Show resolved Hide resolved
@julien-deramond julien-deramond force-pushed the main-his-dark-mode-navs-tabs branch from d127832 to 311de37 Compare October 25, 2023 06:40
@julien-deramond julien-deramond merged commit a4564fc into main-jd-dark-mode Oct 25, 2023
13 checks passed
@julien-deramond julien-deramond deleted the main-his-dark-mode-navs-tabs branch October 25, 2023 06:42
@julien-deramond julien-deramond mentioned this pull request Oct 25, 2023
julien-deramond added a commit that referenced this pull request Oct 26, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Oct 31, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 3, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 3, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 3, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 6, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 7, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 8, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 10, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 13, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 15, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 29, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 30, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 1, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 4, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 8, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 15, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 18, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 21, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 26, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Jan 2, 2024
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color mode Temporary label to highlight color mode issues
Projects
Development

Successfully merging this pull request may close these issues.

3 participants