-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode: Navs & tabs #2307
Merged
julien-deramond
merged 1 commit into
main-jd-dark-mode
from
main-his-dark-mode-navs-tabs
Oct 25, 2023
Merged
Dark mode: Navs & tabs #2307
julien-deramond
merged 1 commit into
main-jd-dark-mode
from
main-his-dark-mode-navs-tabs
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
added
the
color mode
Temporary label to highlight color mode issues
label
Oct 12, 2023
louismaximepiton
requested changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I wasn't clear, but all ids mentionned here need a little shift. For instance:
tab2-content
tab3-content
tab4-content
linkB
linkC
linkD
louismaximepiton
approved these changes
Oct 17, 2023
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
October 25, 2023 06:01
8ae7abe
to
670f453
Compare
julien-deramond
force-pushed
the
main-his-dark-mode-navs-tabs
branch
from
October 25, 2023 06:31
df92ca1
to
d127832
Compare
julien-deramond
force-pushed
the
main-his-dark-mode-navs-tabs
branch
from
October 25, 2023 06:40
d127832
to
311de37
Compare
julien-deramond
approved these changes
Oct 25, 2023
Merged
julien-deramond
added a commit
that referenced
this pull request
Oct 26, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Oct 31, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 3, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 3, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 3, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 6, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 7, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 8, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 10, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 13, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 15, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 29, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 30, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 1, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 4, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 8, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 18, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 21, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 26, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Jan 2, 2024
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Navs & tabs in dark mode, by using existing Sass vars :
$nav-tabs-link-hover-border-color
$border-color
var(--#{$prefix}highlight-color)
$nav-underline-border-color
$gray-500
var(--#{$prefix}border-color-translucent)
$nav-underline-link-active-color
var(--#{$prefix}emphasis-color)
var(--#{$prefix}hover-color)
$nav-underline-link-hover-color
$accessible-orange
var(--#{$prefix}link-hover-color)
$nav-underline-link-active-bg
var(--#{$prefix}body-bg)
transparent
❓ do we need to keep these vars ? (only in Boosted)$nav-underline-link-active-border-color
$accessible-orange
var(--#{$prefix}link-hover-color)
$nav-tabs-link-hover-color
--bs-nav-tabs-link-hover-color
var(--#{$prefix}highlight-color)
$nav-tabs-link-hover-bg
--bs-nav-tabs-link-hover-bg
var(--#{$prefix}highlight-bg)
New CSS variable
--bs-tab-content-border-color
in.nav-tabs
Links