Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: List group #2321

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 18, 2023

Description

List group in dark mode, by using existing Sass vars :

Sass var Previous value New value
$list-group-bg var(--#{$prefix}body-bg) transparent
$list-group-active-color $white var(--#{$prefix}highlight-color)
$list-group-active-bg $black var(--#{$prefix}highlight-bg)
$list-group-disabled-color $gray-500 var(--#{$prefix}disabled-color)
$list-group-action-color $black $list-group-color
$list-group-action-hover-color $primary var(--#{$prefix}link-hover-color)

Links

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Oct 18, 2023
@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 6f95309
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6544e1e51a7793000891fe0c
😎 Deploy Preview https://deploy-preview-2321--boosted.netlify.app/docs/5.3/dark-mode
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton force-pushed the main-jd-dark-mode-list-group branch from 81b31f6 to d25bef6 Compare October 25, 2023 07:24
@julien-deramond julien-deramond force-pushed the main-jd-dark-mode branch 2 times, most recently from df0ac35 to 22bf6d9 Compare October 31, 2023 05:19
@julien-deramond
Copy link
Contributor

Due to the work we've done on list groups on main, this PR needs to be rebased onto main-jd-dark-mode and has the following conflicts:

  • scss/_variables.scss
  • site/content/docs/5.3/dark-mode.md

On top of that, this PR should fix a new issue due to the way we modified the data palette: https://deploy-preview-2223--boosted.netlify.app/docs/5.3/components/list-group/#variants. As you can see, the loop used to display the list group variants doesn't work anymore.

@louismaximepiton louismaximepiton force-pushed the main-jd-dark-mode-list-group branch from d25bef6 to 6aa643c Compare October 31, 2023 14:50
@louismaximepiton
Copy link
Member Author

Should be fixed now. However, we'll need to rethink the palette.yml to make it work in https://deploy-preview-2223--boosted.netlify.app/docs/5.3/customize/color/#functional-colors. TBH, I don't know how to make it work properly, since there are some dependencies.

@julien-deramond julien-deramond force-pushed the main-jd-dark-mode branch 2 times, most recently from 03af5c3 to f49a3ee Compare November 3, 2023 11:30
@julien-deramond julien-deramond force-pushed the main-jd-dark-mode-list-group branch from 6aa643c to 730dd40 Compare November 3, 2023 11:49
@julien-deramond julien-deramond self-requested a review November 3, 2023 12:05
@julien-deramond julien-deramond merged commit 3ce3321 into main-jd-dark-mode Nov 3, 2023
13 checks passed
@julien-deramond julien-deramond deleted the main-jd-dark-mode-list-group branch November 3, 2023 12:06
@julien-deramond julien-deramond mentioned this pull request Nov 3, 2023
julien-deramond added a commit that referenced this pull request Nov 3, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 6, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 7, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 8, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 10, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 13, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 15, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 29, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 30, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 1, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 4, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 8, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 15, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 18, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 21, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 26, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Jan 2, 2024
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color mode Temporary label to highlight color mode issues
Projects
Development

Successfully merging this pull request may close these issues.

2 participants