-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode: List group #2321
Dark mode: List group #2321
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
8ae7abe
to
670f453
Compare
81b31f6
to
d25bef6
Compare
df0ac35
to
22bf6d9
Compare
Due to the work we've done on list groups on main, this PR needs to be rebased onto main-jd-dark-mode and has the following conflicts:
On top of that, this PR should fix a new issue due to the way we modified the data palette: https://deploy-preview-2223--boosted.netlify.app/docs/5.3/components/list-group/#variants. As you can see, the loop used to display the list group variants doesn't work anymore. |
d25bef6
to
6aa643c
Compare
Should be fixed now. However, we'll need to rethink the |
03af5c3
to
f49a3ee
Compare
6aa643c
to
730dd40
Compare
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Description
List group in dark mode, by using existing Sass vars :
$list-group-bg
var(--#{$prefix}body-bg)
transparent
$list-group-active-color
$white
var(--#{$prefix}highlight-color)
$list-group-active-bg
$black
var(--#{$prefix}highlight-bg)
$list-group-disabled-color
$gray-500
var(--#{$prefix}disabled-color)
$list-group-action-color
$black
$list-group-color
$list-group-action-hover-color
$primary
var(--#{$prefix}link-hover-color)
Links