Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: Popovers #2325

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 18, 2023

Description

Modals in dark mode, by using existing Sass vars :

Sass var Previous value New value
$popover-header-color $headings-color var(--#{$prefix}heading-color)
$headings-color inherit $black

⚠️ Need a data-bs-theme="body" somehow ?
⚠️ Change in $headings-color and probably need to check everything that depends from that (var(--#{$prefix}heading-color), etc...)

Links

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Oct 18, 2023
@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 32e3113
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/653b5c5824360b0008980127
😎 Deploy Preview https://deploy-preview-2325--boosted.netlify.app/docs/5.3/content/typography
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond merged commit bcad6e1 into main-jd-dark-mode Oct 27, 2023
13 checks passed
@julien-deramond julien-deramond deleted the main-lmp-popovers-dark branch October 27, 2023 06:45
@julien-deramond julien-deramond mentioned this pull request Oct 27, 2023
julien-deramond added a commit that referenced this pull request Oct 31, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 3, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 3, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 3, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 6, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 7, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 8, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 10, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 13, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 15, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 29, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 30, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 1, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 4, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 8, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 15, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 18, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 21, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 26, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Jan 2, 2024
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color mode Temporary label to highlight color mode issues
Projects
Development

Successfully merging this pull request may close these issues.

2 participants