Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode: Progress bars #2326

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Dark mode: Progress bars #2326

merged 6 commits into from
Oct 31, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 18, 2023 •
edited
Loading

Description

Progress bars in dark mode, by using existing Sass vars :

Sass var Previous value New value
$progress-bg var(--#{$prefix}secondary-bg) var(--#{$prefix}active-bg)
$progress-bar-color $black var(--#{$prefix}highlight-color)
$progress-bar-bg $primary var(--#{$prefix}link-hover-color)

⚠️ Need a check on all colors of this progress before going to review.
⚠️ Not quite sure to use the right variables here.

Links

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Oct 18, 2023
@netlify
Copy link

netlify bot commented Oct 18, 2023 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit a972159
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6540b8b1c4b8ae00083d88bc
😎 Deploy Preview https://deploy-preview-2326--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton marked this pull request as ready for review October 25, 2023 09:23
@julien-deramond julien-deramond force-pushed the main-jd-dark-mode branch 2 times, most recently from df0ac35 to 22bf6d9 Compare October 31, 2023 05:19
@julien-deramond
Copy link
Contributor

The badges in the Orange navbar are written in white, shouldn't it be the same here in light mode?

Screenshot 2023-10-31 at 08 34 11

@julien-deramond julien-deramond self-requested a review October 31, 2023 08:31
julien-deramond
julien-deramond approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the elements we have currently, I'm fine with the content of this PR. However I'll add the remaining questions to tackle in the main PR description.

@julien-deramond julien-deramond merged commit e6ac018 into main-jd-dark-mode Oct 31, 2023
13 checks passed
@julien-deramond julien-deramond deleted the main-lmp-progress-dark branch October 31, 2023 08:32
@julien-deramond julien-deramond mentioned this pull request Oct 31, 2023
Merged
julien-deramond added a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
92ad05b 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
f2cfb14 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
90c4c69 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 6, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
d3bfaa5 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 7, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
19b8155 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 8, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
d578089 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 10, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
69e95a4 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 13, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
c437c65 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 15, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
c371215 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
32192e1 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
3d22d40 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
8f88fb7 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 29, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
b2fe432 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 30, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
52983c1 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 1, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
12898d1 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 4, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
3baae02 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 8, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
12a0bd0 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 15, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
ad56fe2 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 18, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
6a71370 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 21, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
5e59314 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 26, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
62fad3d 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
ddd66d0 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Jan 2, 2024
@louismaximepiton @julien-deramond
Dark mode: Progress bars (#2326)
ee02130 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
color mode Temporary label to highlight color mode issues
Projects
🟣 [Orange-Boosted-Bootstrap] PRs Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louismaximepiton @julien-deramond