-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode: Toasts #2380
Merged
Merged
Dark mode: Toasts #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismaximepiton
added
the
color mode
Temporary label to highlight color mode issues
label
Nov 14, 2023
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
November 15, 2023 06:20
449b31f
to
8d5980c
Compare
julien-deramond
force-pushed
the
main-lmp-toasts-dark
branch
from
November 15, 2023 06:21
4cb935c
to
d3e3e51
Compare
julien-deramond
suggested changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things to finalize before merging
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
November 27, 2023 05:26
82355a2
to
f254ccf
Compare
julien-deramond
force-pushed
the
main-lmp-toasts-dark
branch
from
November 27, 2023 05:30
d3e3e51
to
431fa34
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
November 27, 2023 08:14
f254ccf
to
a8f8146
Compare
julien-deramond
force-pushed
the
main-lmp-toasts-dark
branch
from
November 27, 2023 08:15
431fa34
to
8ffc46f
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
November 27, 2023 12:33
a8f8146
to
5f15275
Compare
julien-deramond
force-pushed
the
main-lmp-toasts-dark
branch
3 times, most recently
from
November 29, 2023 06:13
0f7605e
to
e054b9c
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
November 29, 2023 10:05
ada073f
to
7078b21
Compare
julien-deramond
force-pushed
the
main-lmp-toasts-dark
branch
from
November 29, 2023 10:13
e054b9c
to
0107e8a
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
November 30, 2023 09:46
b0b2994
to
631c377
Compare
julien-deramond
force-pushed
the
main-lmp-toasts-dark
branch
from
November 30, 2023 09:47
0107e8a
to
d934354
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
December 1, 2023 05:56
631c377
to
55af6af
Compare
julien-deramond
force-pushed
the
main-lmp-toasts-dark
branch
from
December 1, 2023 05:57
d934354
to
2c4ddda
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
2 times, most recently
from
December 8, 2023 13:15
9e809b1
to
3841382
Compare
julien-deramond
force-pushed
the
main-lmp-toasts-dark
branch
from
December 8, 2023 13:22
2c4ddda
to
5f4cd0e
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
December 15, 2023 08:32
db6a8fc
to
11ea5fa
Compare
julien-deramond
force-pushed
the
main-lmp-toasts-dark
branch
from
December 15, 2023 08:33
5f4cd0e
to
99d5614
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
December 18, 2023 09:26
cd206e8
to
40ca82c
Compare
julien-deramond
force-pushed
the
main-lmp-toasts-dark
branch
2 times, most recently
from
December 19, 2023 10:06
9dfbbd6
to
e346e2e
Compare
julien-deramond
approved these changes
Dec 19, 2023
julien-deramond
force-pushed
the
main-lmp-toasts-dark
branch
from
December 19, 2023 10:17
e346e2e
to
acd506a
Compare
Merged
julien-deramond
added a commit
that referenced
this pull request
Dec 21, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 26, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Jan 2, 2024
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tweaked a bit the documentation to be consistent.
Remaining question from the dark mode PR description:
Previews