Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: Toasts #2380

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Dark mode: Toasts #2380

merged 2 commits into from
Dec 19, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Nov 14, 2023

Description

Tweaked a bit the documentation to be consistent.

Remaining question from the dark mode PR description:

Need to have data-bs-theme="inverted" for .*bg-secondary (toasts color schemes)?

Previews

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Nov 14, 2023
Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 27e3849
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/65816e4e1410f100085bd7dc
😎 Deploy Preview https://deploy-preview-2380--boosted.netlify.app/docs/5.3/dark-mode
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things to finalize before merging

site/content/docs/5.3/components/toasts.md Show resolved Hide resolved
site/content/docs/5.3/components/toasts.md Show resolved Hide resolved
@julien-deramond julien-deramond force-pushed the main-lmp-toasts-dark branch 3 times, most recently from 0f7605e to e054b9c Compare November 29, 2023 06:13
@julien-deramond julien-deramond force-pushed the main-jd-dark-mode branch 2 times, most recently from 9e809b1 to 3841382 Compare December 8, 2023 13:15
@julien-deramond julien-deramond force-pushed the main-lmp-toasts-dark branch 2 times, most recently from 9dfbbd6 to e346e2e Compare December 19, 2023 10:06
@julien-deramond julien-deramond merged commit 87f750a into main-jd-dark-mode Dec 19, 2023
11 of 12 checks passed
@julien-deramond julien-deramond deleted the main-lmp-toasts-dark branch December 19, 2023 10:21
@julien-deramond julien-deramond mentioned this pull request Dec 19, 2023
julien-deramond added a commit that referenced this pull request Dec 21, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 26, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Jan 2, 2024
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color mode Temporary label to highlight color mode issues
Projects
Development

Successfully merging this pull request may close these issues.

2 participants