Dark mode: Local nav and nav underline fix #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismaximepiton
added
fix
color mode
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Discussed with the designers, we need to use |
louismaximepiton
force-pushed
the
main-lmp-local-nav-fix
branch
from
ba1dbd3 to
5e5825a
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
db6a8fc to
11ea5fa
Compare
julien-deramond
force-pushed
the
main-lmp-local-nav-fix
branch
from
5e5825a to
570cdd3
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
cd206e8 to
40ca82c
Compare
julien-deramond
force-pushed
the
main-lmp-local-nav-fix
branch
from
570cdd3 to
4ce825a
Compare
julien-deramond
force-pushed
the
main-lmp-local-nav-fix
branch
from
4ce825a to
ffecf36
Compare
Merged
julien-deramond
added a commit
that referenced
this pull request
Dec 21, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 26, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Jan 2, 2024
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR safely removes
--bs-nav-link-active-color.Following design private conversation:
The artboards have been updated.
I tweaked a bit the associated CSS to follow these new rules. (Less Generated CSS)
Should be transparent for users (apart for the look).
Live previews