Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode: Spinners doc fix #2410

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Dark mode: Spinners doc fix #2410

merged 1 commit into from
Dec 13, 2023

Conversation

louismaximepiton
Copy link
Member

Description

This PR tackles the following sub-task defined in #2223 description:

Remove data-bs-theme="dark" for buttons containing spinners. This should go if we modify color: automatically with [data-bs-theme]. Otherwise, the only solution would be to have something like .text-body-inverted that we want to avoid.

Live preview

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Dec 13, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 13, 2023

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 4f54602
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6579d3b2ced0b5000898aa95
😎 Deploy Preview https://deploy-preview-2410--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond merged commit 01df287 into main-jd-dark-mode Dec 13, 2023
17 checks passed
@julien-deramond julien-deramond deleted the main-lmp-dark-spinners-doc-fix branch December 13, 2023 18:59
@julien-deramond julien-deramond mentioned this pull request Dec 13, 2023
Merged
julien-deramond pushed a commit that referenced this pull request Dec 15, 2023
@louismaximepiton @julien-deramond
Dark mode: Spinner in buttons (#2410)
73fd204
julien-deramond pushed a commit that referenced this pull request Dec 18, 2023
@louismaximepiton @julien-deramond
Dark mode: Spinner in buttons (#2410)
cdb624e
julien-deramond pushed a commit that referenced this pull request Dec 21, 2023
@louismaximepiton @julien-deramond
Dark mode: Spinner in buttons (#2410)
4f093ae
julien-deramond pushed a commit that referenced this pull request Dec 26, 2023
@louismaximepiton @julien-deramond
Dark mode: Spinner in buttons (#2410)
3844643
julien-deramond pushed a commit that referenced this pull request Dec 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Spinner in buttons (#2410)
2f45677
julien-deramond pushed a commit that referenced this pull request Jan 2, 2024
@louismaximepiton @julien-deramond
Dark mode: Spinner in buttons (#2410)
4983159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
color mode Temporary label to highlight color mode issues
Projects
🟣 [Orange-Boosted-Bootstrap] PRs Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louismaximepiton @julien-deramond