Dark mode: Navbar Color Schemes #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
added
the
color mode
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
force-pushed
the
main-jd-dark-mode-navbar-color-schemes
branch
3 times, most recently
from
24f2ffc to
1e555ae
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
db6a8fc to
11ea5fa
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode-navbar-color-schemes
branch
from
1e555ae to
bb8cb44
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
from
cd206e8 to
40ca82c
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode-navbar-color-schemes
branch
from
bb8cb44 to
d0e467f
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode-navbar-color-schemes
branch
from
0643af7 to
0a49ef0
Compare
julien-deramond
added a commit
that referenced
this pull request
Dec 21, 2023
julien-deramond
added a commit
that referenced
this pull request
Dec 26, 2023
julien-deramond
added a commit
that referenced
this pull request
Dec 27, 2023
julien-deramond
added a commit
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tackles the following sub-task:
This idea is to render the examples to show how
.navbar-darkis no longer useful and how it works now with thedata-bs-themeattribute.Please note that these 3 examples are not exactly the ones from Bootstrap and are slightly adapted to look like actual Boosted navbars.
I haven't add them into a
<details><summary>section since the whole page it not compatible with ODS rules.Live preview