Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: Table fix #2418

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Conversation

louismaximepiton
Copy link
Member

Description

Following the design updates for the dark mode.

⚠️ These changes might be breaking for users. I think it's feasible to make it non-breaking but it means more difficult to maintain + Keep some useless CSS in our Bundle.
⚠️ The striped rows are going from #f6f6f6 (eq: $gray-200) to #000000 (eq: $black). It's almost --bs-tertiary-bg
⚠️ Should we remove dark variant (or at least from all examples) ? Seeing the doc in dark mode feels really weird

Live previews

@louismaximepiton louismaximepiton added fix color mode Temporary label to highlight color mode issues labels Dec 14, 2023
Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 1a345ab
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/658167dbdeb2130008cac865
😎 Deploy Preview https://deploy-preview-2418--boosted.netlify.app/docs/5.3/content/tables
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond force-pushed the main-lmp-table-fix-design branch from 3f16781 to a084cae Compare December 19, 2023 08:21
site/content/docs/5.3/content/tables.md Outdated Show resolved Hide resolved
site/content/docs/5.3/content/tables.md Outdated Show resolved Hide resolved
site/content/docs/5.3/content/tables.md Outdated Show resolved Hide resolved
site/content/docs/5.3/content/tables.md Outdated Show resolved Hide resolved
site/content/docs/5.3/content/tables.md Outdated Show resolved Hide resolved
site/content/docs/5.3/content/tables.md Outdated Show resolved Hide resolved
site/content/docs/5.3/content/tables.md Outdated Show resolved Hide resolved
site/content/docs/5.3/content/tables.md Outdated Show resolved Hide resolved
site/content/docs/5.3/content/tables.md Outdated Show resolved Hide resolved
site/content/docs/5.3/content/tables.md Outdated Show resolved Hide resolved
@julien-deramond julien-deramond self-requested a review December 19, 2023 09:53
@julien-deramond julien-deramond merged commit ca86257 into main-jd-dark-mode Dec 19, 2023
14 checks passed
@julien-deramond julien-deramond deleted the main-lmp-table-fix-design branch December 19, 2023 10:14
@julien-deramond julien-deramond mentioned this pull request Dec 19, 2023
julien-deramond added a commit that referenced this pull request Dec 21, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 26, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Jan 2, 2024
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color mode Temporary label to highlight color mode issues fix passed design review
Projects
Development

Successfully merging this pull request may close these issues.

2 participants