Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: rework Color Modes pages #2442

Merged

Conversation

julien-deramond
Copy link
Contributor

@julien-deramond julien-deramond commented Dec 27, 2023

Description

This PR revamps the Color Modes page by taking into account some remaining sub-tasks from #2223:

Boosted documentation to explain this concept in the color modes page (dark variant vs dark mode) or maybe just in the migration guide? + link in all dark variant components to this section

Color modes: _color-modes.md should explain in detail the impact and the usage of data-bs-theme (color, background-color, contextual, container contextual vs component contextual, the difference with dark variant, etc.)

Live previews

Copy link

netlify bot commented Dec 27, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit a4e16fd
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/658c0059dec2420008b795cc
😎 Deploy Preview https://deploy-preview-2442--boosted.netlify.app/docs/5.3/customize/color-modes
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond force-pushed the main-jd-dark-mode-rework-color-modes-page branch from 8aa0707 to 833ef71 Compare December 27, 2023 08:42
@julien-deramond julien-deramond force-pushed the main-jd-dark-mode-rework-color-modes-page branch from 833ef71 to cb372c9 Compare December 27, 2023 10:40
@julien-deramond julien-deramond merged commit cabe651 into main-jd-dark-mode Dec 27, 2023
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-dark-mode-rework-color-modes-page branch December 27, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants