Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: add a warning callout to Orange's colors section #2444

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

julien-deramond
Copy link
Contributor

@julien-deramond julien-deramond commented Dec 27, 2023

Description

This PR adds a warning callout to the "Orange's colors" section to precise that the light mode rules must be applied when a text can be seen on both light and dark backgrounds.

This was a sub-task identified in #2223:

Colors: Rework docs/5.3/utilities/colors/#oranges-colors to explain it clearly

Live previews

@julien-deramond julien-deramond added the color mode Temporary label to highlight color mode issues label Dec 27, 2023
Copy link

netlify bot commented Dec 27, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 8e1a6ad
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/658c0250edbee500085e9eee
😎 Deploy Preview https://deploy-preview-2444--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond force-pushed the main-jd-dark-mode-oranges-colors branch from b83c609 to 9e27814 Compare December 27, 2023 10:49
@julien-deramond julien-deramond merged commit 7281b26 into main-jd-dark-mode Dec 27, 2023
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-dark-mode-oranges-colors branch December 27, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color mode Temporary label to highlight color mode issues
Projects
Development

Successfully merging this pull request may close these issues.

2 participants